1442937 - Make Credentials menu collapse on select

Status: RESOLVED FIXED

(Taskcluster :: UI, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

(from https://github.com/taskcluster/taskcluster-tools/issues/311)

You can see the issue by selecting one of the "Sign In" options on the "Sign In" menu. A new window opens, but if you go back to the original window, there's the menu still hanging out, open.

It should close once an item is selected.

Comment 1

[Andin Fokunang]

Hello Dustin, may I work on this? (In reply to Dustin J. Mitchell [:dustin] pronoun: he from comment #0)

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Please do!

Comment 3

[Andin Fokunang]

Thanks! I will get started right away

Comment 4

[Andin Fokunang]

Sorry for the long silence!!
I seem to be confused on the location of the SignIn menu. I would like to confirm if the actual file is /taskcluster-tools/src/auth , because when I try to make changes in the NavItem, I don't see the changes I have made.

Am I modifying the wrong file?

Comment 5

[Andin Fokunang]

I have seen what the problem is.
When I clicked on the menu item, it directs me to the online version of the application rather than the local version on my computer. That is what got me confused.
I will continue working and give more updates as i progress

Comment 6

[Andin Fokunang]

I have understood what the problem was. Actually, it was me getting all confused!

I have fixed the bug using a workaround, as this seems to be a problem with react bootstrap itself.
Please, how do I proceed to submit my work?

Comment 7

[Hassan Ali (:hassan)]

Hi Andin. You can go ahead and send a pull-request to the taskcluster-tools repository.

Comment 8

[Hashini Galappaththi]

Is this closed or Shall I start working on this?

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

I don't see a PR for it.

Comment 10

[Hassan Ali (:hassan)]

This is fixed in tc-web.