1442968 - Add thunderbird.net to pontoon.mozilla.org

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: Administration / Setup, task)

Description

[Andrei Hajdukewycz [:sancus]]

Hi,

I'm not sure exactly what the process for this is. I'd like to add thunderbird.net as a separate project, maybe "Thunderbird Website" to Pontoon for translation.

We've been using .lang files from bedrock but soon Thunderbird will be removed from mozilla.org in Bug 1388914 and so I've converted our translations over to gettext files.

The gettext files are at: https://github.com/thundernest/thunderbird.net-l10n

Comment 1

[Francesco Lodolo [:flod]]

The repository doesn't have a source language, and I'm pretty sure it should have a template for that (.pot, not .po) in /templates. 

See also
https://developer.mozilla.org/en-US/docs/Mozilla/Implementing_Pontoon_in_a_Mozilla_website

Comment 2

[Andrei Hajdukewycz [:sancus]]

I added the .pot file -- is that all that's needed or is there some way to define a source language that I'm missing?

I also invited the mozilla-pontoon user to the repository. I'll go over that documentation again tomorrow and add the other things(list of locales, list of page urls for in-page localization and add the JS file to the website I think are the items).

Comment 3

[Francesco Lodolo [:flod]]

> list of page urls for in-page localization and add the JS file to the website

These are only needed for the in-content localization, which is optional.

Comment 4

[Andrei Hajdukewycz [:sancus]]

(In reply to Francesco Lodolo [:flod] from comment #3)
> > list of page urls for in-page localization and add the JS file to the website
> 
> These are only needed for the in-content localization, which is optional.

Yeah I saw that. I don't think it's super important for us to have that right away, but maybe we want it eventually. Is it widely used by the active localizers?

Project Name: Thunderbird.net
Repository URL: https://github.com/thundernest/thunderbird.net-l10n
Website URL(s): https://www.thunderbird.net/ and https://start.thunderbird.net/ (or the start page in your TB client)
Locales: 'ach', 'af', 'an', 'ar', 'as', 'ast', 'az', 'be', 'bg', 'bn-BD', 'bn-IN', 'br', 'bs', 'ca', 'cak', 'cs',
    'cy', 'da', 'de', 'dsb', 'el', 'en-GB', 'en-US', 'en-ZA', 'eo', 'es-AR', 'es-CL', 'es-ES', 'es-MX', 'et',
    'eu', 'fa', 'ff', 'fi', 'fr', 'fy-NL', 'ga-IE', 'gd', 'gl', 'gn', 'gu-IN', 'he', 'hi-IN', 'hr', 'hsb',
    'hu', 'hy-AM', 'id', 'is', 'it', 'ja', 'ka', 'kab', 'kk', 'km', 'kn', 'ko', 'lij', 'lt', 'ltg', 'lv',
    'mai', 'mk', 'ml', 'mr', 'ms', 'my', 'nb-NO', 'ne-NP', 'nl', 'nn-NO', 'oc', 'or', 'pa-IN', 'pl', 'pt-BR', 'pt-PT',
    'rm', 'ro', 'ru', 'si', 'sk', 'sl', 'son', 'sq', 'sr', 'sv-SE', 'ta', 'te', 'th', 'tr', 'uk', 'ur',
    'uz', 'vi', 'xh', 'zh-CN', 'zh-TW', 'zu'

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Andrei Hajdukewycz [:sancus] from comment #4)
> Yeah I saw that. I don't think it's super important for us to have that
> right away, but maybe we want it eventually. Is it widely used by the active
> localizers?

I'm not sure how many projects we have using it, I'm only aware of Pontoon Intro.

Comment 6

[Andrei Hajdukewycz [:sancus]]

Anything else I need to do here or any specific person I need to ping?

Comment 7

[Francesco Lodolo [:flod]]

Sync in Pontoon is failing, but I can't understand why: it seems to be looking for a /templates/ab-CD/LC_MESSAGES/messages.pot when parsing the ab-CD locale file.

@Matjaz
Any idea? We have other projects with locales in the root (e.g. Mozillians), so that shouldn't be the cause. Files open correctly locally.

Mar 13 05:32:08 mozilla-pontoon app/worker.1: Skipping resource bs/LC_MESSAGES/messages.po due to ParseError: Failed to parse /app/media/projects/thunderbirdnet/[e-mail]:thundernest/thunderbird.net-l10n.git/templates/bs/LC_MESSAGES/messages.pot: Syntax error in po file None (line 1) 
Mar 13 05:32:08 mozilla-pontoon app/worker.1: [2018-03-13 05:32:08,489: ERROR/Worker-61] Skipping resource bs/LC_MESSAGES/messages.po due to ParseError: Failed to parse /app/media/projects/thunderbirdnet/[e-mail]:thundernest/thunderbird.net-l10n.git/templates/bs/LC_MESSAGES/messages.pot: Syntax error in po file None (line 1) 
Mar 13 05:32:08 mozilla-pontoon app/worker.1: Changed files in Thunderbird.net repository: [u'templates/LC_MESSAGES/messages.po'] 

etc.

Comment 8

[Matjaz Horvat [:mathjazz]]

Clearing NI just to report I'm looking into this.

As the first step I tried to sync with one locale locally and it works fine.

Comment 9

[Matjaz Horvat [:mathjazz]]

The project is now up:
https://pontoon.mozilla.org/projects/thunderbirdnet/

I had to force sync. Judging from the Traceback message above, the sync was failing because the Repository URL was off originally, which left garbage in the filesystem, which made Pontoon fail when detecting where the files are.

Also, two Resources were defined as "Production site", I took the liberty of renaming one to "Start page".

Comment 10

[Andrei Hajdukewycz [:sancus]]

Thanks!

One question: Is pontoon's commit rate to the repository limited to once every 20 minutes as it appears?

Comment 11

[Matjaz Horvat [:mathjazz]]

Correct.

Comment 12

[Axel Hecht [:Pike]]

Technically speaking, we run sync every 20 minutes right now. That's both repo->pontoon and pontoon->repo. The commits are per locale, and push per commit, so there is more activity in the target repo if there's more than one locale active in a sync cycle.

Comment 13

[Peiying Mo [:CocoMo]]

Andrei, the project info is added to Pontoon.

Comment 14

[Francesco Lodolo [:flod]]

Two questions:
* Is there a stage server?
* How exactly was the import done? Because there are errors, at least for Italian, with translations absolutely not matching the source.

Donate to Thunderbird -> translated as "Download Thunderbird"
Contribute to Thunderbird -> translated as "Contribute to the website"

Did you run the merge and accept fuzzy matches as approved, assuming that's even possible?

Comment 15

[Peiying Mo [:CocoMo]]

(In reply to Francesco Lodolo [:flod] from comment #14)
> Two questions:
> * Is there a stage server?
I have updated the project info, including staging servers: https://pontoon.mozilla.org/projects/thunderbirdnet/info/

Comment 16

[Andrei Hajdukewycz [:sancus]]

(In reply to Francesco Lodolo [:flod] from comment #14)
> * How exactly was the import done? Because there are errors, at least for
> Italian, with translations absolutely not matching the source.

Well, these strings were all in .lang files before, not in gettext files. So I had to write my own script to import. There was apparently a bug that caused mis-translations of a few short strings. I believe it was only 3:
;Welcome to <span>Thunderbird</span>
;Donate to Thunderbird
;Contribute to Thunderbird

It looks like you've cleared and re-translated these for Italian, but I'll need to write a new script to go through and fix all the other languages. I'll do that today.

Thanks!

Comment 17

[Andrei Hajdukewycz [:sancus]]

Those 3 strings should be fixed now. I noticed it/pl manually fixed it, so I didn't touch those languages. For the others, I reimported the correct translation if it was available, and if not, emptied the msgstr so it should show up as needing translation.

Comment 18

[Ton [:Tonnes]]

I noticed these 2 strings:

Contribute - (still) uses l10n for "Contribute to this site"
Need support? - uses l10n for "Support"

Do they need fixing and are they still required?

Additionally, I don’t think %s in "Download %s in your language" is used on the web page. As this may affect l10n, is fixing %s required, or should it just use "Thunderbird" instead?

Comment 19

[Andrei Hajdukewycz [:sancus]]

(In reply to Ton [:Tonnes] from comment #18)
> I noticed these 2 strings:
> 
> Contribute - (still) uses l10n for "Contribute to this site"
> Need support? - uses l10n for "Support"
> 
> Do they need fixing and are they still required?

Thanks! They did need fixing, and I've fixed them.

> Additionally, I don’t think %s in "Download %s in your language" is used on
> the web page. As this may affect l10n, is fixing %s required, or should it
> just use "Thunderbird" instead?

It is. %s is the channel name, it can be nothing or it can be "Beta" like on https://www.thunderbird.net/en-US/thunderbird/beta/all/.

Comment 20

[Ton [:Tonnes]]

(In reply to Andrei Hajdukewycz [:sancus] from comment #19)

> Thanks! They did need fixing, and I've fixed them.

Thanks.

> It is. %s is the channel name, it can be nothing or it can be "Beta" like on
> https://www.thunderbird.net/en-US/thunderbird/beta/all/.

Can you clarify? I dare to doubt this. %s is called channel_name in the TB code all right [1], but in all.lang it’s replaced by the product name [2], i.e. Firefox for FF. Also, Beta strings use their own "Download Beta in your language" text for instance, both for FF (if still used, but I don’t think so) and TB.

Either way and in case the purpose is that %s _can_ be omitted (i.e. to use Beta or nothing), sharing the string may affect l10n as grammar rules may not allow simply omitting the product name / object, but I just think something is failing here. Or to put it differently and simple: the header should read "Download Thunderbird in your language" for the regular product page instead, similar to Firefox [4], shouldn’t it?

Do note that the issue also occurred on [5] and [6], so prior to the move. That doesn’t mean it’s OK though - yet archived pages indicate it was before [7] - so this may be a good time to fix it. An easy way would be to use "Thunderbird" rather than %s if %s is not used in any other way.

I also tend to think it was never intended to use channel names without product names in this string, which may have been the reason for the issue to occur. I.e. omitting a channel name would be fine when sharing, but not without the product name ("Download Thunderbird %s in your language"?), and even that may not apply to all locales.

[1] https://github.com/thundernest/thunderbird-website/blob/master/website/thunderbird/all/index.html#L10
[2] https://github.com/mozilla-l10n/www.mozilla.org/blob/master/en-US/firefox/all.lang#L11
[3] https://transvision.mozfr.org/?recherche=download+in+your+language&repo=mozilla_org&sourcelocale=en-US&locale=en-US&search_type=strings&each_word=each_word
[4] https://www.mozilla.org/en-US/firefox/all/
[5] https://www.mozilla.org/en-US/thunderbird/all/
[6] https://www.mozilla.org/en-US/thunderbird/beta/all/
[7] https://web.archive.org/web/20151030133142/https://www.mozilla.org/en-US/thunderbird/all/

Comment 21

[Andrei Hajdukewycz [:sancus]]

You're right, it looks like a bug crept in at some point on the Mozilla side and it wasn't noticed. It should definitely be "Download Thunderbird in your language."

We also only use it in that one place, on the non-beta /all page, so I'm just going to change that string in the template and extract/merge strings today.

Thanks for your help!!