Update FlattenIntoArray to call IsArray only if depth > 0

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: anba, Assigned: evilpie)

Tracking

Trunk
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 wontfix, firefox61 wontfix, firefox62 fixed)

Details

()

Attachments

(1 attachment)

Reporter

Description

a year ago
Update FlattenIntoArray per <https://github.com/tc39/proposal-flatMap/pull/55>
Priority: -- → P2
Assignee

Comment 1

a year ago
This change was motivated by optimizing flat and flatMap. I think we need to keep flatMap as self-hosted JS to get the inlining benefit, but flat(ten) should be faster in C++.
Assignee

Comment 2

a year ago
Okay, I am going to implement this so we can enable flat/flatMap in release. Implementing FlattenIntoArray in C++ turned out to be a lot more annoying than I anticipated.
Assignee

Updated

a year ago
Assignee: nobody → evilpies
Assignee

Updated

a year ago
Attachment #8983380 - Flags: review?(andrebargull)
Reporter

Comment 4

a year ago
Comment on attachment 8983380 [details] [diff] [review]
Update FlattenIntoArray to call IsArray only if depth > 0. r?

Review of attachment 8983380 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8983380 - Flags: review?(andrebargull) → review+

Comment 5

a year ago
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e91926fbe44
Update FlattenIntoArray to call IsArray only if depth > 0. r=anba

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0e91926fbe44
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.