Compilation on ARM fail in ANGLE: g++: error: unrecognized command line option '-msse2'

RESOLVED FIXED in Firefox 60

Status

defect
RESOLVED FIXED
Last year
Last year

People

(Reporter: ashie, Assigned: m_kato)

Tracking

Trunk
mozilla60
ARM
Linux
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(2 attachments)

Posted file Full build log
Compilation of Firefox against Renesas RZ/G1M (Linux/ARM) is failed after bug1440849 is landed:

  13:09.41 arm-poky-linux-gnueabi-g++: error: unrecognized command line option '-msse2'
  13:09.41 /home/vagrant/rzg1-bsp/build/tmp/work/cortexa15hf-vfp-neon-poky-linux-gnueabi/firefox/git-r0/git/config/rules.mk:1047: recipe for target 'Float16ToFloat32.o' failed
  13:09.41 make[4]: *** [Float16ToFloat32.o] Error 1
  13:09.41 /home/vagrant/rzg1-bsp/build/tmp/work/cortexa15hf-vfp-neon-poky-linux-gnueabi/firefox/git-r0/git/config/recurse.mk:73: recipe for target 'gfx/angle/targets/angle_common/target' failed
  13:09.41 make[3]: *** [gfx/angle/targets/angle_common/target] Error 2

It seems that it's a similar issue with bug1434589.
Blocks: angle-60
Product: Core → Firefox Build System
Comment on attachment 8956346 [details]
Bug 1443088 - Don't use SSE2 flag on non-Intel platform.

https://reviewboard.mozilla.org/r/225206/#review231888

::: gfx/angle/moz.build.common:3
(Diff revision 1)
>  AllowCompilerWarnings()
>  
> +if CONFIG['INTEL_ARCHITECTURE']:

Does this mean x86, or Intel specifically? I'm assuming AMD+SSE2 would be supported by this?
(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> Comment on attachment 8956346 [details]
> Bug 1443088 - Don't use SSE2 flag on non-Intel platform.
> 
> https://reviewboard.mozilla.org/r/225206/#review231888
> 
> ::: gfx/angle/moz.build.common:3
> (Diff revision 1)
> >  AllowCompilerWarnings()
> >  
> > +if CONFIG['INTEL_ARCHITECTURE']:
> 
> Does this mean x86, or Intel specifically? I'm assuming AMD+SSE2 would be
> supported by this?

INTEL_ARCHITECTURE means x86 and x86_64 target includes all intel compatible CPU (Intel, AMD, VIA and etc)
Comment on attachment 8956346 [details]
Bug 1443088 - Don't use SSE2 flag on non-Intel platform.

https://reviewboard.mozilla.org/r/225206/#review231892
Attachment #8956346 - Flags: review?(jgilbert) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/5fa8ee6d00d7
Don't use SSE2 flag on non-Intel platform. r=jgilbert
https://hg.mozilla.org/mozilla-central/rev/5fa8ee6d00d7
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Assignee: nobody → m_kato
You need to log in before you can comment on or make changes to this bug.