Closed Bug 1443091 Opened 6 years ago Closed 6 years ago

[GTK] IMContextWrapper shouldn't treat KeyboardEvents as "processed by IME" if it's handled as dead key

Categories

(Core :: Widget: Gtk, defect)

All
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod, regression)

Attachments

(1 file)

This is regression of patches (note that they won't be landed on Nightly) of bug 1343451.

I forgot to handle dead key on Linux specially. We should keep key value of dead key as "Dead" rather than "Process".
Comment on attachment 8957758 [details]
Bug 1443091 - IMContextWrapper should dispatch eKeyDown and eKeyUp event as "Dead" keys rather than "Process" if user pressed a dead key

https://reviewboard.mozilla.org/r/226732/#review232646
Attachment #8957758 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/e0181f1b31ad
IMContextWrapper should dispatch eKeyDown and eKeyUp event as "Dead" keys rather than "Process" if user pressed a dead key r=m_kato
https://hg.mozilla.org/mozilla-central/rev/e0181f1b31ad
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: