Closed Bug 1443106 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 9801 - [css-typed-om] Fix crash when appending var refs.

Categories

(Core :: DOM: CSS Object Model, enhancement, P3)

Product:
Core
Component:
DOM: CSS Object Model
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 9801 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9801
Details from upstream follow.

Darren Shen wrote:
>  [css-typed-om] Fix crash when appending var refs.
>  
>  We currently hit a DCHECK when appending a var ref. This patch fixes
>  the crash by rejecting it as per the spec.
>  
>  Spec: https://github.com/w3c/css-houdini-drafts/commit/ecfcbf9721c0d7dff7890d8e009e4e3ad9b72d10
>  Change-Id: I144307bf489db5e968c8e326087d13554ec3e59c
>  Reviewed-on: https://chromium-review.googlesource.com/948142
>  WPT-Export-Revision: 04c1cbf048455606273d99136b964a30a34f417e
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 4 tests and 4 subtests
OK     : 4
FAIL   : 4
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7d2294b8949
[wpt PR 9801] - [css-typed-om] Fix crash when appending var refs., a=testonly
https://hg.mozilla.org/mozilla-central/rev/c7d2294b8949
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.