Closed Bug 1443121 Opened 2 years ago Closed 2 years ago
Use new redux-connect wrapper for the Console
59 bytes, text/x-review-board-request
Bug 1419350 introduced a helper function that wraps Redux's `connect()` method and uses `VisibilityHandler` component as HOC. This construct can be consequently used to ignore Redux updates to avoid rendering when a panel is running in background. This helper should be also used in the Console panel (ConsoleOutput component) The helper should go into to be easily shared: devtools/client/shared/redux/redux-connect.js file Honza
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Priority: -- → P2
Comment on attachment 8956046 [details] Bug 1443121 - Use new redux-connect wrapper for the Console; https://reviewboard.mozilla.org/r/224990/#review230934 A couple of minor comments, but this is good to go :) ::: commit-message-69f9a:1 (Diff revision 1) > +Bug 1443121 - Use new redux-connect wrapper for the Console; r=nchevobbe > + maybe add that the the file was renamed and that netmonitor now requires it with an absolute path ::: devtools/client/shared/redux/moz.build:12 (Diff revision 1) > DIRS += [ > 'middleware', > ] > > DevToolsModules( > + 'connect.js', nit: Perhaps we could name it visibility-aware-connect.js so it's more obvious how it is different from the regular react-redux's connect ?
Attachment #8956046 - Flags: review?(nchevobbe) → review+
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #2) > maybe add that the the file was renamed and that netmonitor now requires it > with an absolute path Done > nit: Perhaps we could name it visibility-aware-connect.js so it's more > obvious how it is different from the regular react-redux's connect ? Done I used `visibility-handler-connect.js` since the implementation is based on `VisibilityHandler` component. Thanks Nicolas! Honza
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/55b683e679b0 Use new redux-connect wrapper for the Console; r=nchevobbe
You need to log in before you can comment on or make changes to this bug.