144316 - Setting up the makefiles for mozilla/security/nss/cmd/tests

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[Wan-Teh Chang]

I asked Bishakha to add new NSS tests.  This bug is about
how these tests will get built.

The current proposal is that all the new tests will be added
to the mozilla/security/nss/cmd/tests directory, with each
test consisting of one .c file (as opposed to creating one
subdirectory for each test).  Moreover, these new tests
won't be included in the binary distributions (jar files).

I will attach the manifest.mn and Makefile for
mozilla/security/nss/cmd/tests.

Comment 1

[Wan-Teh Chang]

Attachment: manifest.mn

The most important part of this manifest.mn file is the
last three statements:

PROGRAMS = $(CSRCS:.c=$(PROG_SUFFIX))

This constructs the PROGRAMS list from the CSRCS list.
coreconf installs $(PROGRAMS) under the dist directory.

TARGETS = $(PROGRAMS)

This tells the libs and install targets of coreconf to
build $(PROGRAMS).  By default, coreconf builds $(PROGRAM)
or $(LIBRARY).

NO_MD_RELEASE = 1

This tells coreconf to exclude $(PROGRAMS) from the binary
distribution jar files.

Comment 2

[Wan-Teh Chang]

Attachment: Makefile

This is the same as the Makefile in the existing
mozilla/security/nss/cmd/<test name> directories.

Comment 3

[Bishakha Banerjee]

Attachment: Manifest file

This is a slightly modified manifest.mn file. I made the modification to get
the tests to compile. I forgot to submit this for review earlier this week.

It is just a one-line change from using the PROG_SUFFIX variable to using "exe"
instead. Using the PROG_SUFFIX variable resulted in ".exe" being appended twice
to the file.

Comment 4

[Wan-Teh Chang]

Comment on attachment 84960 [details]
Manifest file

There are commented-out lines for CSRCS, PROGRAMS, and PROGRAM
in this file.  Please delete them.

I see what's wrong with my manifest.mn.  coreconf/ruleset.mk
adds $(PROG_SUFFIX), so we don't need to do that.  Thanks for
catching that error.

Your solution is incorrect because it is evaluating the
variable "exe", which is undefined:
  PROGRAMS = $(CSRCS:.c=$(exe))

So it is equivalent to
  PROGRAMS = $(CSRCS:.c=)
which is what we should be using.

Comment 5

[Bishakha Banerjee]

Attachment: updated manifest file

Sorry, updated the bug in a hurry, and forgot to attach the clean manifest
file.

Here is the cleaned one, with the commented out lines removed, and Wan-Teh's
correction to the PROGRAMS variable

Comment 6

[Wan-Teh Chang]

Comment on attachment 84965 [details]
updated manifest file

This one is good.  r=wtc.  Thanks, Bishakha!

Comment 7

[Bishakha Banerjee]

Attachment: script to run and display results of tests in nss/cmd/tests

This is the script that will need to be modified every time a new test is
created.
This script currently is similar to the other scripts in the other tests
directories.

Wan-Teh has suggested modifying this script such that each small test within
nss/cmd/tests is just a one-line call of the test (just the test-name) with
expected error code

Comment 8

[Bishakha Banerjee]

Attachment: cmdtests script in text format

the script in text format

Comment 9

[Bishakha Banerjee]

Attachment: script with placeholder for one test taken out

There was a placeholder for one of the three tests that I need to fill in.
Taking that out for now.

Comment 10

[Bishakha Banerjee]

Will open a new bug, assigned to myself, on the enhancement to the test script