Closed Bug 1443184 Opened 3 years ago Closed 3 years ago

browser_markup_accessibility_semantics.js fails when converted to async/await instead of Task

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: ochameau, Assigned: ystartsev)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

$ ./mach mochitest devtools/client/inspector/markup/test/browser_markup_accessibility_semantics.js

fails with this error:
TEST-PASS | devtools/client/inspector/markup/test/browser_markup_accessibility_semantics.js | Non expandable tree items should not have aria-expanded attribute - 
TEST-PASS | devtools/client/inspector/markup/test/browser_markup_accessibility_semantics.js | Closed tree item should have aria-expanded unset - 
Selecting and expanding list container
Selecting the node for 'ul'
TEST-PASS | devtools/client/inspector/markup/test/browser_markup_accessibility_semantics.js | Active descendant should not be set to list container tagLine - 
TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_accessibility_semantics.js | Open tree item should have aria-expanded set - Got false, expected true
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1271
chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_accessibility_semantics.js:null:82

Note that may be related to bug 1441531 as this test also uses waitForMultipleChildrenUpdates.
Priority: -- → P3
I made this change against the most recent central -- it seems to be passing after building. I am running the tests on try to confirm.
Assignee: nobody → ystartsev
Comment on attachment 8965245 [details]
Bug 1443184 - update browser_markup_accessibility_semantics.js to use async/await.

https://reviewboard.mozilla.org/r/233960/#review239722

Thanks Yulia!
Attachment #8965245 - Flags: review?(poirot.alex) → review+
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a9f8278bf31
update browser_markup_accessibility_semantics.js to use async/await. r=ochameau
https://hg.mozilla.org/mozilla-central/rev/8a9f8278bf31
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.