1443184 - browser_markup_accessibility_semantics.js fails when converted to async/await instead of Task

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

$ ./mach mochitest devtools/client/inspector/markup/test/browser_markup_accessibility_semantics.js

fails with this error:
TEST-PASS | devtools/client/inspector/markup/test/browser_markup_accessibility_semantics.js | Non expandable tree items should not have aria-expanded attribute - 
TEST-PASS | devtools/client/inspector/markup/test/browser_markup_accessibility_semantics.js | Closed tree item should have aria-expanded unset - 
Selecting and expanding list container
Selecting the node for 'ul'
TEST-PASS | devtools/client/inspector/markup/test/browser_markup_accessibility_semantics.js | Active descendant should not be set to list container tagLine - 
TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_accessibility_semantics.js | Open tree item should have aria-expanded set - Got false, expected true
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1271
chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_accessibility_semantics.js:null:82

Note that may be related to bug 1441531 as this test also uses waitForMultipleChildrenUpdates.

Comment 1

[Yulia Startsev [:yulia]]

Attachment: Bug 1443184 - update browser_markup_accessibility_semantics.js to use async/await.

Review commit: https://reviewboard.mozilla.org/r/233960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233960/

Comment 2

[Yulia Startsev [:yulia]]

I made this change against the most recent central -- it seems to be passing after building. I am running the tests on try to confirm.

Comment 3

[Yulia Startsev [:yulia]]

Tests look good! https://treeherder.mozilla.org/#/jobs?repo=try&revision=e42de2b69fe093406c2b3f90d7c1c1dce1270024

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8965245 [details]
Bug 1443184 - update browser_markup_accessibility_semantics.js to use async/await.

https://reviewboard.mozilla.org/r/233960/#review239722

Thanks Yulia!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a9f8278bf31
update browser_markup_accessibility_semantics.js to use async/await. r=ochameau

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8a9f8278bf31