Debugger should not include babel-traverse

RESOLVED FIXED in Firefox 60

Status

defect
P1
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: jlast, Assigned: jlast)

Tracking

unspecified
Firefox 60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60+ fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

No description provided.
Posted patch rel-19-2.patch (obsolete) — Splinter Review
Attachment #8956145 - Flags: review?(jdescottes)
Blocks: 1439839
Comment on attachment 8956145 [details] [diff] [review]
rel-19-2.patch

Review of attachment 8956145 [details] [diff] [review]:
-----------------------------------------------------------------

This needs to be rebased now that Bug 1440102 landed (few minutes ago)  

Two suggestions:
- could we mention release v19.2 in the commit message? 
- since the patch is huge, it would be useful to have a comment here explaining why the patch is 5MB

::: devtools/client/debugger/new/test/mochitest/browser_dbg-babel-scopes.js
@@ +85,5 @@
>    is(getScopeLabel(dbg, items.length + 1), "Window");
>  }
>  
>  add_task(async function() {
> +  requestLongerTimeout(4);

This will conflict with my patch from Bug 1440102 (also I moved this line on top of the file)
Attachment #8956145 - Flags: review?(jdescottes) → review+
Julien: this is the second (and last) part of the fixes we would like to land to reduce the size of the Debugger bundle files. As far as I understand there is no new feature here, but we are removing one of our dependencies in favor of another library that we already used, hence reducing the size of the code we ship. I'll let Jason provide more details if needed.
Assignee: nobody → jlaster
Status: NEW → ASSIGNED
Flags: needinfo?(jcristau)
Priority: -- → P1
cool. I'll rebase and update the commit message.
Posted patch rel-19-3.patch (obsolete) — Splinter Review
Attachment #8956145 - Attachment is obsolete: true
Attachment #8956294 - Flags: review?(jdescottes)
Thanks.
Flags: needinfo?(jcristau)
Attachment #8956294 - Flags: review?(jdescottes) → review+
wrong bug number in commit message
Attachment #8956294 - Attachment is obsolete: true
Attachment #8956384 - Flags: review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd7752d5a392
Release debugger v19.2 (remove reference to babel-traverse);r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/dd7752d5a392
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.