Closed Bug 1443204 Opened 2 years ago Closed 2 years ago

Remove org.mozilla.geckoview.BuildConfig generation in moz.build

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

enhancement
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(2 files)

This is yet another "special moz.build" -> "standard Gradle" transition.  We no longer need to generate BuildConfig.java using GENERATED_FILES at https://searchfox.org/mozilla-central/rev/d2b4b40901c15614fad2fa34718eea428774306e/mobile/android/base/moz.build#121.
Attachment #8956898 - Flags: review?(core-build-config-reviews) → review?(cmanchester)
Attachment #8956899 - Flags: review?(core-build-config-reviews) → review?(cmanchester)
Comment on attachment 8956898 [details]
Bug 1443204 - Pre: Clean-up unused Android data structures in mozbuild frontend.

https://reviewboard.mozilla.org/r/225858/#review231778
Attachment #8956898 - Flags: review?(cmanchester) → review+
Comment on attachment 8956899 [details]
Bug 1443204 - Remove org.mozilla.geckoview.BuildConfig generation in moz.build.

https://reviewboard.mozilla.org/r/225860/#review231780
Attachment #8956899 - Flags: review?(cmanchester) → review+
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e3a7560b4206
Pre: Clean-up unused Android data structures in mozbuild frontend. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/eb1dfa51050f
Remove org.mozilla.geckoview.BuildConfig generation in moz.build. r=chmanchester
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c3d771dd55db
Backed out 2 changesets for build bustages at mozbuild/test/frontend/test_emitter.py on a CLOSED TREE
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c15be736fff0
Pre: Clean-up unused Android data structures in mozbuild frontend. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/7989f5d56e52
Remove org.mozilla.geckoview.BuildConfig generation in moz.build. r=chmanchester
Attachment #8956898 - Flags: review?(core-build-config-reviews)
Attachment #8956899 - Flags: review?(core-build-config-reviews)
https://hg.mozilla.org/mozilla-central/rev/c15be736fff0
https://hg.mozilla.org/mozilla-central/rev/7989f5d56e52
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 60 → mozilla60
You need to log in before you can comment on or make changes to this bug.