Closed
Bug 1443226
Opened 6 years ago
Closed 6 years ago
Port bug 1434476 and bug 1439734 to TB
Categories
(Thunderbird :: Theme, enhancement)
Thunderbird
Theme
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 60.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(2 files)
3.17 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
166.54 KB,
application/x-xpinstall
|
Details |
This bug is to port: bug 1434476 - Allow changing the background color of the selected tab. bug 1439734 - Allow setting the tab line color.
Assignee | ||
Comment 1•6 years ago
|
||
This is a port of bug 1434476: https://hg.mozilla.org/mozilla-central/rev/65f5b5e79d2e with changes in ThemeVariableMap.jsm and tabmail.css. and bug 1439734: https://hg.mozilla.org/mozilla-central/rev/f7f3f1c04fcd with only change in ThemeVariableMap.jsm. I attach a test theme and explain there what you should see.
Assignee | ||
Comment 2•6 years ago
|
||
The other test theme has no background images and then the selected tab doesn't get a different colour (m-c decision). The selected tab should be light blue and the tab line at the top of the active tab should be red. I apply this red only to this tabs. The tabs in calendar and the side tabs in chat still get the blue line. I decided to do it this way because this two tabs never get the background image of the main tab and it could be the main tabs get a dark background and the tab line will be white. Then the white tab line could apply to the white calendar- and chat tabs which doesn't look so good.
Comment 3•6 years ago
|
||
Comment on attachment 8956156 [details] [diff] [review] LWT-TabColors.patch Looks OK to me. I had a live demonstration via video conference since I haven't built with the necessary M-C changes.
Attachment #8956156 -
Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/bda7b4ec2e7b Port bug 1434476 and bug 1439734 to TB (tab background color and tab line color). r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 60.0
You need to log in
before you can comment on or make changes to this bug.
Description
•