1443234 - Port bug 1442961 to TB: Remove the windowdragbox element and binding

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Richard Marti (:Paenglab)]

Bug 1442961 removes the windowdragbox binding. We don't really need this one and can follow m-c and change the windowdragbox to vbox or hbox.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: windowdragbox.patch

This is a port of https://reviewboard.mozilla.org/r/224870/diff/2#index_header

We do not need to wait until it lands on m-c as we go away from the binding.
I checked on Linux that the titlebar is still dragable.

Comment 2

[Jorg K (CEST = GMT+2)]

Any visual changes or changes in behaviour? What does a windowdragbox do?

Comment 3

[Richard Marti (:Paenglab)]

No visual change. Like the name suggests it is probably for the dragging but except of the titlebar I see no reason why it was used in the prefs-, chat-account or activity window.

On main window, with drawInTitlebar all empty areas around the tabs should be usable for dragging, also with menubar enabled.

Comment 4

[Richard Marti (:Paenglab)]

The m-c bug landed already.

Comment 5

[Jorg K (CEST = GMT+2)]

Yes, on autoland, I'll take care of it now.

Comment 6

[Jorg K (CEST = GMT+2)]

Sorry, already merged, too.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8956163 [details] [diff] [review]
windowdragbox.patch

I see no difference and windows can still be dragged. Landing this now.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fa9449081261
Port bug 1442961 to TB: Remove the windowdragbox element and binding. r=jorgk