Closed Bug 1443234 Opened 2 years ago Closed 2 years ago

Port bug 1442961 to TB: Remove the windowdragbox element and binding

Categories

(Thunderbird :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 60.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Bug 1442961 removes the windowdragbox binding. We don't really need this one and can follow m-c and change the windowdragbox to vbox or hbox.
This is a port of https://reviewboard.mozilla.org/r/224870/diff/2#index_header

We do not need to wait until it lands on m-c as we go away from the binding.
I checked on Linux that the titlebar is still dragable.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8956163 - Flags: review?(jorgk)
Any visual changes or changes in behaviour? What does a windowdragbox do?
No visual change. Like the name suggests it is probably for the dragging but except of the titlebar I see no reason why it was used in the prefs-, chat-account or activity window.

On main window, with drawInTitlebar all empty areas around the tabs should be usable for dragging, also with menubar enabled.
The m-c bug landed already.
Yes, on autoland, I'll take care of it now.
Sorry, already merged, too.
Comment on attachment 8956163 [details] [diff] [review]
windowdragbox.patch

I see no difference and windows can still be dragged. Landing this now.
Attachment #8956163 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fa9449081261
Port bug 1442961 to TB: Remove the windowdragbox element and binding. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 60.0
You need to log in before you can comment on or make changes to this bug.