1443242 - Policy: Block about:debugging when InstallAddons -> Default=false is in use

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, defect)

Description

[Mike Kaply [:mkaply]]

We need to disable about:debugging. I see a few options.

1. Add a unique policy.
2. Disable as part of disabling add-on installs.
3. Disable as part of the developer tools policies.

Thoughts?

Comment 1

[:Felipe Gomes (needinfo for replies!)]

We can make it as part of _both_ add-on installs or developer tools..

As an example, we added disabling devtools.chrome.enabled to DisableAboutConfig too

Comment 2

[Kanika Saini]

Attachment: Bug 1443242 - Disable about:debugging in InstallAddons Policy

Review commit: https://reviewboard.mozilla.org/r/233760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233760/

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8965022 [details]
Bug 1443242 - Disable about:debugging in InstallAddons Policy

https://reviewboard.mozilla.org/r/233758/#review239394

::: browser/components/enterprisepolicies/Policies.jsm:513
(Diff revision 1)
>        if ("Allow" in param) {
>          addAllowDenyPermissions("install", param.Allow, null);
>        }
>        if ("Default" in param) {
>          setAndLockPref("xpinstall.enabled", param.Default);
> +        manager.disallowFeature("about:debugging");

The policy supports locking the "xpinstall.enabled" pref to both true or false. It probably doesn't make a lot of sense as a use-case for someone locking it to true (which is already the default), but it could happen.

So, just to be 100% correct, we only want to block about:debugging when param.Default is false  (i.e., the sys admin is blocking add-ons from being installed)

Comment 4

[Kanika Saini]

Comment on attachment 8965022 [details]
Bug 1443242 - Disable about:debugging in InstallAddons Policy

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233760/diff/1-2/

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8965022 [details]
Bug 1443242 - Disable about:debugging in InstallAddons Policy

https://reviewboard.mozilla.org/r/233760/#review239404

Awesome! Thanks!

I'll land this now

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26c8dafa2070
Disable about:debugging in InstallAddons Policy. r=felipe

Comment 7

[:Felipe Gomes (needinfo for replies!)]

[Tracking Requested - why for this release]:
Enterprise Policies

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8965022 [details]
Bug 1443242 - Disable about:debugging in InstallAddons Policy

Approval Request Comment
[Feature/Bug causing the regression]: Follow-up to bug 1429131
[User impact if declined]: Extensions can be side-loaded through about:debugging, even though the block installs policy is in use
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: qa will verify it
[List of other uplifts needed for the feature/fix]: bug 1429131
[Is the change risky?]: no
[Why is the change risky/not risky?]: uses the same system to block about: pages as other policies
[String changes made/needed]: none

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/26c8dafa2070

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8965022 [details]
Bug 1443242 - Disable about:debugging in InstallAddons Policy

enterprise policy, approved for 60.0b11

Comment 11

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d59384968f0615359d9f64401e73b78baeba0dd2