Closed Bug 1443243 Opened 7 years ago Closed 7 years ago

Preloaded tab is sending impression ping after section was disabled

Categories

(Firefox :: New Tab Page, defect)

Product:
Firefox
Component:
New Tab Page
Version:
60 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- affected

People

(Reporter: csadilek, Assigned: csadilek)

Details

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4019
52 bytes, text/x-github-pull-request
Details | Review
When a preloaded tab becomes visible it will send an impression ping. Activity stream checks to make sure this only happens when the section is expanded (not collapsed), but it also needs to check if the section was disabled in the meantime.
Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/e2452dc433ff23c2a8cb15091c8edebb1cb59b1b Fix Bug 1443243 - Preloaded tab is sending impression ping after section was disabled https://github.com/mozilla/activity-stream/commit/e1ae13a2398f4702d71a0d5b03487618544f104c Merge pull request #4019 from csadilek/1443243 Fix Bug 1443243 - Preloaded tab is sending impression ping after section was disabled
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: