Closed Bug 1443246 Opened 2 years ago Closed 2 years ago
Don't include Robocop APK in tests
59 bytes, text/x-review-board-request
Right now, we sign a Robocop APK during stage-package. AFAICT, it's not used, and it would be better to have all of the Android signing logic in |mach package|. This is undoing parts of Bug 1065773.
In fact, the resulting APK isn't even in the tests.common.zip any more -- see https://queue.taskcluster.net/v1/task/ZvHuzU_CQYWkIRFrei1zSA/runs/0/artifacts/public/build/target.common.tests.zip. And https://searchfox.org/mozilla-central/rev/d2b4b40901c15614fad2fa34718eea428774306e/testing/mozharness/scripts/android_emulator_unittest.py#686 is definitely trying to download it.
Comment on attachment 8956173 [details] Bug 1443246 - Don't sign Robocop APK during stage-package. https://reviewboard.mozilla.org/r/225094/#review231066
Attachment #8956173 - Flags: review?(gbrown) → review+
This required a tiny bit more than gbrown reviewed, but the try builds look fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=91c91b02f6d46549901cafb26b14d617b5b81637
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/6ad76fb89595 Don't sign Robocop APK during stage-package. r=gbrown
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 60 → mozilla60
You need to log in before you can comment on or make changes to this bug.