Closed Bug 1443246 Opened 6 years ago Closed 6 years ago

Don't include Robocop APK in tests.common.zip

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Product:
Firefox Build System
Component:
Android Studio and Gradle Integration
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

Bug 1443246 - Don't sign Robocop APK during stage-package.
59 bytes, text/x-review-board-request
gbrown
: review+
Details 
Right now, we sign a Robocop APK during stage-package.  AFAICT, it's not used, and it would be better to have all of the Android signing logic in |mach package|.

This is undoing parts of Bug 1065773.
Comment on attachment 8956173 [details]
Bug 1443246 - Don't sign Robocop APK during stage-package.

https://reviewboard.mozilla.org/r/225094/#review231066
Attachment #8956173 - Flags: review?(gbrown) → review+
This required a tiny bit more than gbrown reviewed, but the try builds look fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=91c91b02f6d46549901cafb26b14d617b5b81637
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ad76fb89595
Don't sign Robocop APK during stage-package. r=gbrown
Blocks: 1443332
https://hg.mozilla.org/mozilla-central/rev/6ad76fb89595
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 60 → mozilla60
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: