Closed Bug 1443297 Opened 5 years ago Closed 5 years ago

What is HostLayerManager::mCompositorBridgeID and why is it only 32 bits?

Categories

(Core :: Graphics: Layers, enhancement)

Other Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/d2b4b40901c15614fad2fa34718eea428774306e/gfx/layers/composite/LayerManagerComposite.h#211-217,227

It's 32 bits. The setter/getter functions take/return 32 bit values. But all the things that call those setters and getters provide and expect a 64-bit value.
Matt, you seem to have been the reviewer. Any guesses why?
Flags: needinfo?(matt.woodrow)
Whiteboard: [gfx-noted]
The patch I reviewed just moved the code from Compositor to HostLayerManager, the mismatch has been around for longer. I haven't dug into the history further, since I doubt it matters, we should just switch it to 64bit.

Looks like it's used to lookup the right top-level CompositorBridge to schedule a composite when we get an async video frame pushed. Nical might remember more about why it works this why if you want to follow this further :)
Flags: needinfo?(matt.woodrow)
I'll just fix this.
Assignee: nobody → bugmail
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4756e7e36f45a2d2f5fc88ed1d563cd101db53a9
Summary: What is LayerManagerComposite::mCompositorBridgeID and why is it only 32 bits? → What is HostLayerManager::mCompositorBridgeID and why is it only 32 bits?
Comment on attachment 8958857 [details]
Bug 1443297 - Fix sizing error for HostLayerManager::mCompositorBridgeID.

https://reviewboard.mozilla.org/r/227738/#review233492
Attachment #8958857 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28707a88967e
Fix sizing error for HostLayerManager::mCompositorBridgeID. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/28707a88967e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.