Closed
Bug 1443319
Opened 5 years ago
Closed 5 years ago
Removing unnecessary generator on waitForAnimationTimelineRendering breaks browser_animation_timeline_rate_selector.js
Categories
(DevTools :: Inspector: Animations, defect, P2)
DevTools
Inspector: Animations
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: ochameau, Assigned: yulia)
References
Details
Attachments
(1 file, 1 obsolete file)
With the following patch: $ ./mach mochitest devtools/client/animationinspector/test/browser_animation_timeline_rate_selector.js fails with: Select just one animated node and change its rate only Selecting the node for '.animated' Console message: [JavaScript Error: "A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'? See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise Date: Mon Mar 05 2018 14:10:40 GMT-0800 (PST) Full Message: Protocol error (noSuchActor): No such actor for ID: server1.conn0.child1/animationplayer53 This block Task.jsm removal from animation inspector folder as switching all generators to async also breaks this test with the same error.
Comment hidden (mozreview-request) |
No longer blocks: 1440321
Blocks: 1365607
Updated•5 years ago
|
Priority: -- → P2
Comment hidden (mozreview-request) |
Assignee | ||
Updated•5 years ago
|
Attachment #8956244 -
Attachment is obsolete: true
Reporter | ||
Updated•5 years ago
|
Assignee: nobody → ystartsev
Reporter | ||
Comment 3•5 years ago
|
||
mozreview-review |
Comment on attachment 8964583 [details] Bug 1443319 - Remove unnecessary generator on waitForAnimationTimelineRendering https://reviewboard.mozilla.org/r/233302/#review238908 It looks like you were working on an old version of mozilla-central. The fix looks good if it still works after rebase. Thanks for looking into that. ::: devtools/client/animationinspector/test/head.js:361 (Diff revision 1) > // Simulate the right events to select the option in the drop-down. > EventUtils.synthesizeMouseAtCenter(select, {type: "mousedown"}, win); > EventUtils.synthesizeMouseAtCenter(option, {type: "mouseup"}, win); > > yield onUiUpdated; > - yield onRendered; > + yield waitForAnimationTimelineRendering(panel); You would have to rebase as this method is now using await. Does that still work on try after rebase?
Attachment #8964583 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Comment 4•5 years ago
|
||
Looks like this change is no longer necessary as it is already in central: https://searchfox.org/mozilla-central/source/devtools/client/animationinspector/test/head.js#382
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Updated•5 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•