1443419 - Snap: GTK dialogs are not translated

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ken VanDine]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/64.0.3282.167 Chrome/64.0.3282.167 Safari/537.36

Steps to reproduce:

The snap bundles firefox translations but not the GTK translations.

Comment 1

[Ken VanDine]

Attachment: Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap.

Review commit: https://reviewboard.mozilla.org/r/225236/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225236/

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8956372 [details]
Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap.

https://reviewboard.mozilla.org/r/225236/#review231268

I thought adding the packages would increase significantly the package size. On the 59.0rc snap:
* built without this patch: 185MB[1]
* with: 187MB.

Let's get these strings localized.

[1] https://queue.taskcluster.net/v1/task/GzujpZ9vTgqQcXtJaReq5g/runs/1/artifacts/public/build/firefox-59.0.snap

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32c3c20fd489
Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. r=jlorenzo

Comment 4

[Tiberius Oros[:tiberius_oros]]

Backed out changeset 32c3c20fd489 (bug 1443419) for shell failure on /firefox-snap/runme.sh:53 on CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=166210671

https://hg.mozilla.org/integration/autoland/rev/031b19788dfcff8743238dd46416333060f64245

Comment 5

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. p=kenvandine

Review commit: https://reviewboard.mozilla.org/r/225864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225864/

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8956372 [details]
Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap.

The only difference between the new patch and this one, is that I disabled the check that failed the linter. Thanks to the --wildcard, the glob is expanded.

Comment 7

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8956903 [details]
Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. p=kenvandine


Approval Request Comment
[Feature/Bug causing the regression]: None
[User impact if declined]: GTK windows on Snap aren't localized. The rest of the product is.
[Is this code covered by automated tests?]: N/A
[Has the fix been verified in Nightly?]: N/A. Releng crafts Snap on beta. Starting Firefox 59, Snap are also built on release.
[Needs manual test from QE? If yes, steps to reproduce]: No. This has been tested by Canonical's QA.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is a Snap only fix for 59. It has no impact on the regular product.
[String changes made/needed]: None.

Comment 8

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8956903 [details]
Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. p=kenvandine

One more uplift for 59. This should only affect the snap builds.

Comment 9

[Simon Fraser [:sfraser] ⌚️GMT]

Comment on attachment 8956903 [details]
Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. p=kenvandine

https://reviewboard.mozilla.org/r/225864/#review231858

Nice, good catching of the unpacking errors

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7efade306e9e
Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. p=kenvandine r=sfraser

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7efade306e9e

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8956903 [details]
Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. p=kenvandine

Sorry, was told to punt on this for now to avoid possibly delaying the RC3 build.

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 8956903 [details]
Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. p=kenvandine

60 is on m-r now, too late for 59.