Closed Bug 1443419 Opened 4 years ago Closed 4 years ago

Snap: GTK dialogs are not translated

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
Tracking Status
firefox60 --- fixed

People

(Reporter: ken.vandine, Assigned: ken.vandine)

References

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/64.0.3282.167 Chrome/64.0.3282.167 Safari/537.36

Steps to reproduce:

The snap bundles firefox translations but not the GTK translations.
Comment on attachment 8956372 [details]
Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap.

https://reviewboard.mozilla.org/r/225236/#review231268

I thought adding the packages would increase significantly the package size. On the 59.0rc snap:
* built without this patch: 185MB[1]
* with: 187MB.

Let's get these strings localized.

[1] https://queue.taskcluster.net/v1/task/GzujpZ9vTgqQcXtJaReq5g/runs/1/artifacts/public/build/firefox-59.0.snap
Attachment #8956372 - Flags: review?(jlorenzo) → review+
Pushed by jlorenzo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32c3c20fd489
Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. r=jlorenzo
Assignee: nobody → ken.vandine
Blocks: snappy
Comment on attachment 8956372 [details]
Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap.

The only difference between the new patch and this one, is that I disabled the check that failed the linter. Thanks to the --wildcard, the glob is expanded.
Attachment #8956372 - Attachment is obsolete: true
Comment on attachment 8956903 [details]
Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. p=kenvandine


Approval Request Comment
[Feature/Bug causing the regression]: None
[User impact if declined]: GTK windows on Snap aren't localized. The rest of the product is.
[Is this code covered by automated tests?]: N/A
[Has the fix been verified in Nightly?]: N/A. Releng crafts Snap on beta. Starting Firefox 59, Snap are also built on release.
[Needs manual test from QE? If yes, steps to reproduce]: No. This has been tested by Canonical's QA.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is a Snap only fix for 59. It has no impact on the regular product.
[String changes made/needed]: None.
Attachment #8956903 - Flags: approval-mozilla-release?
Comment on attachment 8956903 [details]
Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. p=kenvandine

One more uplift for 59. This should only affect the snap builds.
Attachment #8956903 - Flags: approval-mozilla-release? → approval-mozilla-release+
Comment on attachment 8956903 [details]
Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. p=kenvandine

https://reviewboard.mozilla.org/r/225864/#review231858

Nice, good catching of the unpacking errors
Attachment #8956903 - Flags: review?(sfraser) → review+
Pushed by jlorenzo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7efade306e9e
Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. p=kenvandine r=sfraser
https://hg.mozilla.org/mozilla-central/rev/7efade306e9e
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Comment on attachment 8956903 [details]
Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. p=kenvandine

Sorry, was told to punt on this for now to avoid possibly delaying the RC3 build.
Attachment #8956903 - Flags: approval-mozilla-release+ → approval-mozilla-release?
Comment on attachment 8956903 [details]
Bug 1443419 - Extract gtk30.mo files from all the Ubuntu langpacks and bundle them into the snap. p=kenvandine

60 is on m-r now, too late for 59.
Attachment #8956903 - Flags: approval-mozilla-release? → approval-mozilla-release-
See Also: → 1623696
You need to log in before you can comment on or make changes to this bug.