Closed Bug 1443425 Opened 2 years ago Closed 2 years ago
Content Sink::Start Layout: shell Grip is probably useless
https://dxr.mozilla.org/mozilla-central/source/dom/base/nsContentSink.cpp?q=shellgrip&redirect_type=single#1268 Reported as a good first bug.
Hello, I would like to take this as my Good First Bug. Can you assign it to me?
Sure, I will assign it to you once you submitted your first patch! Thanks
Can I take this bug?
Does it look good?
Attachment #8957235 - Attachment is obsolete: true
Looks good, now please try to find an appropriate reviewer!
Assignee: nobody → mmrxyz
Hello, Would you be able to review the patch? Thanks
Please use the appropriate flag for review. see: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed
Comment on attachment 8957240 [details] [diff] [review] Bug1443425_UnusedVariableShellGrip.diff r=me At first I thought we couldn't take this because this was grabbing a strong reference to the shell to avoid it dying from Initialize, but turns out that "shell" is already a strong reference, so this should be fine.
Attachment #8957240 - Flags: review+
But yeah, next time please flag someone with review? instead :) Thanks for your patch!
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/457704c7f810 Removed unused variable shellGrip. r=emilio
Emilio landed the patch for you!
Thank you for fixing! For context, looks like "shell" used to be a raw pointer until bug 378776 was fixed, which is when shellGrip became useless.
You need to log in before you can comment on or make changes to this bug.