Closed
Bug 1443425
Opened 6 years ago
Closed 6 years ago
nsContentSink::StartLayout: shellGrip is probably useless
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: mmrxyz, Mentored)
Details
(Whiteboard: [good first bug][lang=C++])
Attachments
(1 file, 1 obsolete file)
|
725 bytes,
patch
|
emilio
:
review+
|
Details | Diff | Splinter Review |
https://dxr.mozilla.org/mozilla-central/source/dom/base/nsContentSink.cpp?q=shellgrip&redirect_type=single#1268 Reported as a good first bug.
Hello, I would like to take this as my Good First Bug. Can you assign it to me?
|
Reporter | |
Comment 2•6 years ago
|
||
Sure, I will assign it to you once you submitted your first patch! Thanks
|
||
Comment 3•6 years ago
|
||
Can I take this bug?
|
|
Reporter | |
Updated•6 years ago
|
Attachment #8957235 -
Attachment is obsolete: true
Flags: needinfo?(sledru)
|
|
Reporter | |
Comment 7•6 years ago
|
||
Looks good, now please try to find an appropriate reviewer!
Assignee: nobody → mmrxyz
Hello, Would you be able to review the patch? Thanks
Flags: needinfo?(bzbarsky)
|
|
Reporter | |
Comment 9•6 years ago
|
||
Please use the appropriate flag for review. see: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed
Flags: needinfo?(bzbarsky)
|
||
Comment 10•6 years ago
|
||
Comment on attachment 8957240 [details] [diff] [review] Bug1443425_UnusedVariableShellGrip.diff r=me At first I thought we couldn't take this because this was grabbing a strong reference to the shell to avoid it dying from Initialize, but turns out that "shell" is already a strong reference, so this should be fine.
Attachment #8957240 -
Flags: review+
|
|
||
Comment 11•6 years ago
|
||
But yeah, next time please flag someone with review? instead :) Thanks for your patch!
|
|
Reporter | |
Comment 12•6 years ago
|
||
bravo! Next step is https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
|
||
Comment 13•6 years ago
|
||
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/457704c7f810 Removed unused variable shellGrip. r=emilio
Keywords: checkin-needed
|
||
Comment 15•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/457704c7f810
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Comment 16•6 years ago
|
||
Thank you for fixing! For context, looks like "shell" used to be a raw pointer until bug 378776 was fixed, which is when shellGrip became useless.
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•