Closed Bug 1443438 Opened 2 years ago Closed 2 years ago

Modify isInSystemHeader and make it polymorphic matcher

Categories

(Firefox Build System :: Source Code Analysis, enhancement)

3 Branch
enhancement
Not set

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: andi, Assigned: andi)

References

Details

Attachments

(1 file)

In order to be able to use use this matcher on 'Decl' and 'Stmt' like in the bellow example:


>>  AstMatcher->addMatcher(
>>      callExpr(
>>          allOf(
>>              isFirstParty(),
>>              callee(functionDecl(allOf(
>>                  isInSystemHeader(),
>>                  anyOf(
>>                      allOf(anyOf(allOf(hasName("LoadLibraryA"),

we should make this matcher polymorphic.
Comment on attachment 8956381 [details]
Bug 1443438 - Modify matcher isInSystemHeader to be polymorphic.

https://reviewboard.mozilla.org/r/225252/#review231352
Attachment #8956381 - Flags: review?(nika) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f40b3c7a568d
Modify matcher isInSystemHeader to be polymorphic. r=mystor
https://hg.mozilla.org/mozilla-central/rev/f40b3c7a568d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.