1443457 - Stop referencing the "addon-sdk" loader in devtools code

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

The addon-sdk loader was completely copied over to devtools, so "addon-sdk loader" will make less and less sense in the future.

We should rename everything that refers to addonsdk loader (including the test names) to devtools loader?

Comment 1

[Julian Descottes [:jdescottes]]

The original comment referred to devtools/client/webconsole/new-console-output/test/mochitest/browser_console_addonsdk_loader_exception.js

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1443457 - Stop referencing the addon-sdk loader in devtools code

Review commit: https://reviewboard.mozilla.org/r/226448/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226448/

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8957562 [details]
Bug 1443457 - Stop referencing the addon-sdk loader in devtools code

https://reviewboard.mozilla.org/r/226448/#review232364

Thanks Mike, I really only intended to cleanup the test that we migrated, but I guess a bigger cleanup doesn't hurt :)

Let's wait for 61 cycle before landing this and I would also like to get a confirmation about the mochitest json file.

::: devtools/client/debugger/test/mochitest/addon-source/browser_dbg_addon3/lib/main.js:12
(Diff revision 1)
>    }
>  };
>  
>  observerService.addObserver(observer, "debuggerAttached");
>  
>  var sdkLoaderDestroyObserver = {

Maybe rename this variable as well?

::: testing/runtimes/mochitest-devtools-chrome-e10s.runtimes.json:860
(Diff revision 1)
> -    "devtools/client/webconsole/test/browser_console_addonsdk_loader_exception.js": 3748, 
> -    "devtools/client/webconsole/test/browser_console_consolejsm_output.js": 4138, 
> -    "devtools/client/webconsole/test/browser_console_filters.js": 4025, 
> +    "devtools/client/webconsole/test/browser_console_consolejsm_output.js": 4138,
> +    "devtools/client/webconsole/test/browser_console_devtools_loader_exception.js": 3748,
> +    "devtools/client/webconsole/test/browser_console_filters.js": 4025,

it's not clear to me if we should modify this file, let's ask :ahal or :jmaher

Comment 4

[Julian Descottes [:jdescottes]]

Joel, can you confirm if we should update the json file when renaming a test?

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

it would be a good idea to update the json file, that helps balance the runtimes a bit between chunks.  Hopefully we get to a position where we don't need to have these stored in-tree or it is not so delicate in the future.  We update the files very irregularly- possibly it is time to do that or switch our chunking :)

Comment 6

[Julian Descottes [:jdescottes]]

Thanks for the feedback, marking the issue as resolved then!

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8957562 [details]
Bug 1443457 - Stop referencing the addon-sdk loader in devtools code

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226448/diff/1-2/

Comment 8

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s a981656640cc0ffee1c05b4b77b1f802b28ac64c -d df0f95483846: rebasing 451912:a981656640cc "Bug 1443457 - Stop referencing the addon-sdk loader in devtools code r=jdescottes" (tip)
merging devtools/client/framework/devtools-browser.js
merging devtools/client/framework/devtools.js
merging devtools/client/webconsole/new-console-output/test/mochitest/browser_console_addonsdk_loader_exception.js and devtools/client/webconsole/new-console-output/test/mochitest/browser_console_devtools_loader_exception.js to devtools/client/webconsole/new-console-output/test/mochitest/browser_console_devtools_loader_exception.js
merging devtools/server/main.js
merging devtools/server/tests/mochitest/test_getProcess.html
merging devtools/shared/base-loader.js
merging devtools/shared/builtin-modules.js
warning: conflicts while merging devtools/server/tests/mochitest/test_getProcess.html! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8957562 [details]
Bug 1443457 - Stop referencing the addon-sdk loader in devtools code

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226448/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c8540f7800f
Stop referencing the addon-sdk loader in devtools code r=jdescottes

Comment 11

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 2c8540f7800f (bug 1443457) for ESlint failure at /builds/worker/checkouts/gecko/devtools/server/tests/mochitest/test_getProcess.html

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2c8540f7800fcaae3599e6c64154ba9e5ac95f17&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=167880096&repo=autoland&lineNumber=252

Backout: https://hg.mozilla.org/integration/autoland/rev/e5cca677e835e18e0eb74499d5c0448497aa779c

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae1924aff61b
Stop referencing the addon-sdk loader in devtools code r=jdescottes

Comment 13

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8957562 [details]
Bug 1443457 - Stop referencing the addon-sdk loader in devtools code

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226448/diff/3-4/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b98d3bc2333f
Stop referencing the addon-sdk loader in devtools code r=jdescottes

Comment 15

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b4fefc4bb90
Backed out changeset ae1924aff61b as requested by developer

Comment 16

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b98d3bc2333f