Closed
Bug 1443462
Opened 6 years ago
Closed 6 years ago
Set attributes for the initial browser and subsequent browsers in one place
Categories
(Firefox :: Tabbed Browser, enhancement, P3)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
(In reply to Mike Conley (:mconley) (:⚙️) from bug 1442651 comment #15) > ::: browser/base/content/tabbrowser.js:1828 > (Diff revision 4) > > - b.setAttribute("contextmenu", this.getAttribute("contentcontextmenu")); > > - b.setAttribute("tooltip", this.getAttribute("contenttooltip")); > > + b.setAttribute("contextmenu", "contentAreaContextMenu"); > > + b.setAttribute("tooltip", "aHTMLTooltip"); > > FWIW, it might be useful to have the initial set of attributes for each > browser centralized somewhere, to ensure that we keep it and the initial > browser's attributes in the XBL file in sync.
Assignee | ||
Updated•6 years ago
|
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ff249e0b4166b9462642a00971f5a7daefdf8c6
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8959105 [details] Bug 1443462 - Copy default browser attributes from the initial browser to dynamically created ones. https://reviewboard.mozilla.org/r/227978/#review233880 Great, thanks!
Attachment #8959105 -
Flags: review?(mconley) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d556510c483b Copy default browser attributes from the initial browser to dynamically created ones. r=mconley
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d556510c483b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•