1443462 - Set attributes for the initial browser and subsequent browsers in one place

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Description

[Dão Gottwald [:dao]]

(In reply to Mike Conley (:mconley) (:⚙️) from bug 1442651 comment #15)
> ::: browser/base/content/tabbrowser.js:1828
> (Diff revision 4)
> > -    b.setAttribute("contextmenu", this.getAttribute("contentcontextmenu"));
> > -    b.setAttribute("tooltip", this.getAttribute("contenttooltip"));
> > +    b.setAttribute("contextmenu", "contentAreaContextMenu");
> > +    b.setAttribute("tooltip", "aHTMLTooltip");
> 
> FWIW, it might be useful to have the initial set of attributes for each
> browser centralized somewhere, to ensure that we keep it and the initial
> browser's attributes in the XBL file in sync.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1443462 - Copy default browser attributes from the initial browser to dynamically created ones.

Review commit: https://reviewboard.mozilla.org/r/227978/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227978/

Comment 2

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ff249e0b4166b9462642a00971f5a7daefdf8c6

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8959105 [details]
Bug 1443462 - Copy default browser attributes from the initial browser to dynamically created ones.

https://reviewboard.mozilla.org/r/227978/#review233880

Great, thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d556510c483b
Copy default browser attributes from the initial browser to dynamically created ones. r=mconley

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d556510c483b