1443480 - Convert devtools/client/animationinspector from Task.jsm/yield to async/await

Assignee

Description

•

6 years ago

Animation inspector may require a dedicated rewrite as browser_animation_timeline_rate_selector.js starts failing as you rewrite to async/await without simple reasons. It isn't only because of the test rewrite itself, nor just one method in head files.

$ ./mach mochitest devtools/client/animationinspector/test/browser_animation_timeline_rate_selector.js
TEST-PASS | devtools/client/animationinspector/test/browser_animation_timeline_rate_selector.js | The selected rate is empty - 
Change the rate for these mixed-rate animations
TEST-PASS | devtools/client/animationinspector/test/browser_animation_timeline_rate_selector.js | All animations' rates have been set to 1 - 
TEST-PASS | devtools/client/animationinspector/test/browser_animation_timeline_rate_selector.js | The right value is displayed in the select - 
TEST-UNEXPECTED-FAIL | devtools/client/animationinspector/test/browser_animation_timeline_rate_selector.js | A promise chain failed to handle a rejection: Protocol error (noSuchActor): No such actor for ID: server1.conn0.child1/animationplayer53 - stack: null
Rejection date: Mon Mar 05 2018 13:40:02 GMT-0800 (PST) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 251
Stack trace:
    resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:251
    chrome://mochikit/content/browser-test.js:Tester_execTest/<:1089
    Tester_execTest@chrome://mochikit/content/browser-test.js:1058:9
    Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:958:9
    SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
Leaving test bound 
GECKO(67230) | JavaScript error: resource://devtools/shared/base-loader.js -> resource://devtools/shared/protocol.js, line 1222: Error: Connection closed, pending request to server1.conn0.child1/animationplayer62, type getProperties failed
GECKO(67230) | Request stack:
GECKO(67230) | request@resource://devtools/shared/base-loader.js -> resource://devtools/shared/protocol.js:1279:14
GECKO(67230) | generateRequestMethods/</frontProto[name]@resource://devtools/shared/base-loader.js -> resource://devtools/shared/protocol.js:1433:14
GECKO(67230) | getTracks@resource://devtools/shared/base-loader.js -> resource://devtools/client/animationinspector/components/animation-timeline.js:734:28
GECKO(67230) | async*render@resource://devtools/shared/base-loader.js -> resource://devtools/client/animationinspector/components/animation-timeline.js:474:28
GECKO(67230) | async*refreshAnimationsUI@chrome://devtools/content/animationinspector/animation-panel.js:327:5
GECKO(67230) | Async*refreshAnimationsStateAndUI@chrome://devtools/content/animationinspector/animation-panel.js:315:11
GECKO(67230) | async*onRateChanged/<@chrome://devtools/content/animationinspector/animation-panel.js:265:37
GECKO(67230) | promise callback*onRateChanged@chrome://devtools/content/animationinspector/animation-panel.js:264:5
GECKO(67230) | emit@resource://devtools/shared/base-loader.js -> resource://devtools/shared/event-emitter.js:178:37
GECKO(67230) | emit@resource://devtools/shared/base-loader.js -> resource://devtools/shared/event-emitter.js:255:29
GECKO(67230) | onRateChanged@resource://devtools/shared/base-loader.js -> resource://devtools/client/animationinspector/components/rate-selector.js:100:7
GECKO(67230) | doApply@chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:143:10
GECKO(67230) | apply@chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:208:30
GECKO(67230) | synthesizeMouseAtPoint@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:437:26
GECKO(67230) | synthesizeMouse@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:385:10
GECKO(67230) | synthesizeMouseAtCenter@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:483:10
GECKO(67230) | changeTimelinePlaybackRate@chrome://mochitests/content/browser/devtools/client/animationinspector/test/head.js:359:3
GECKO(67230) | async*@chrome://mochitests/content/browser/devtools/client/animationinspector/test/browser_animation_timeline_rate_selector.js:48:9

J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)

Updated

•

6 years ago

No longer blocks: 1440321

J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)

Updated

•

6 years ago

Blocks: 1365607

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/229402/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229402/

Comment hidden (mozreview-request)

$ ./obj-firefox-artifact/dist/bin/run-mozilla.sh ./obj-firefox-artifact/dist/bin/xpcshell xpc devtools/client/animationinspector

Review commit: https://reviewboard.mozilla.org/r/229404/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229404/

Comment hidden (mozreview-request)

$ ./obj-firefox-artifact/dist/bin/run-mozilla.sh ./obj-firefox-artifact/dist/bin/xpcshell xpc devtools/client/animationinspector --replace-generators

Review commit: https://reviewboard.mozilla.org/r/229406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229406/

Comment hidden (mozreview-request)

$ find devtools/client/ animationinspector -type f -exec sed -i 's/async function(/async function (/g' {} \;

Review commit: https://reviewboard.mozilla.org/r/229408/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229408/

Comment hidden (mozreview-request)

find devtools/client/animationinspector/ -type f -exec sed -i '/devtools\/shared\/task/d' {} \;

Review commit: https://reviewboard.mozilla.org/r/229410/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229410/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/229412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229412/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/229414/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229414/

Alexandre Poirot [:ochameau]

Assignee

Comment 8

•

6 years ago

Green try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2fd4949c2ac2d70c5836ed075931728e154a14e3

Alexandre Poirot [:ochameau]

Assignee

Updated

•

6 years ago

Assignee: nobody → poirot.alex

Comment hidden (spam)

Comment on attachment 8960630 [details]
Bug 1443480 - Convert Task.jsm to async/await in devtools/client/animationinspector.

https://reviewboard.mozilla.org/r/229404/#review235130


Code analysis found 10 defects in this patch:
 - 10 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/animationinspector/components/animation-details.js:9
(Diff revision 1)
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  "use strict";
>  
>  const {Task} = require("devtools/shared/task");

Error: 'task' is assigned a value but never used. [eslint: no-unused-vars]

::: devtools/client/animationinspector/components/animation-details.js:94
(Diff revision 1)
>     *                  e.g. { "background-color": "color", }
>     *                         "opacity": "float", ... }
>     */
> -  getAnimationTypes: Task.async(function* (propertyNames) {
> +  async getAnimationTypes(propertyNames) {
>      if (this.serverTraits.hasGetAnimationTypes) {
> -      return yield this.animation.getAnimationTypes(propertyNames);
> +      return await this.animation.getAnimationTypes(propertyNames);

Error: Redundant use of `await` on a return value. [eslint: no-return-await]

::: devtools/client/animationinspector/components/animation-target-node.js:9
(Diff revision 1)
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  "use strict";
>  
>  const {Task} = require("devtools/shared/task");

Error: 'task' is assigned a value but never used. [eslint: no-unused-vars]

::: devtools/client/animationinspector/components/animation-timeline.js:9
(Diff revision 1)
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  "use strict";
>  
>  const { Task } = require("devtools/shared/task");

Error: 'task' is assigned a value but never used. [eslint: no-unused-vars]

::: devtools/client/animationinspector/test/head.js:92
(Diff revision 1)
>   */
> -var selectNodeAndWaitForAnimations = Task.async(
> +var selectNodeAndWaitForAnimations = async function(data, inspector, reason = "test") {
> -  function* (data, inspector, reason = "test") {
>      // We want to make sure the rest of the test waits for the animations to
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:94
(Diff revision 1)
> -  function* (data, inspector, reason = "test") {
>      // We want to make sure the rest of the test waits for the animations to
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:96
(Diff revision 1)
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
> -    yield selectNode(data, inspector, reason);
> +    await selectNode(data, inspector, reason);

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:98
(Diff revision 1)
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
> -    yield selectNode(data, inspector, reason);
> +    await selectNode(data, inspector, reason);
>  
> -    yield onUiUpdated;
> +    await onUiUpdated;

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:99
(Diff revision 1)
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
> -    yield selectNode(data, inspector, reason);
> +    await selectNode(data, inspector, reason);
>  
> -    yield onUiUpdated;
> +    await onUiUpdated;
>      if (AnimationsController.animationPlayers.length !== 0) {

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:103
(Diff revision 1)
> -    yield onUiUpdated;
> +    await onUiUpdated;
>      if (AnimationsController.animationPlayers.length !== 0) {
> -      yield waitForAnimationTimelineRendering(AnimationsPanel);
> -      yield waitForAllAnimationTargets(AnimationsPanel);
> +      await waitForAnimationTimelineRendering(AnimationsPanel);
> +      await waitForAllAnimationTargets(AnimationsPanel);
>      }
> -  }
> +  };

Error: Expected indentation of 0 spaces but found 2. [eslint: indent-legacy]

Comment hidden (spam)

Comment on attachment 8960631 [details]
Bug 1443480 - Convert generators to async functions in devtools/client/animationinspector

https://reviewboard.mozilla.org/r/229406/#review235132


Code analysis found 9 defects in this patch:
 - 9 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/animationinspector/test/browser_animation_detail_displayed.js:84
(Diff revision 1)
>   */
> -function* clickCloseButtonForDetailPanel(timeline, element) {
> +async function clickCloseButtonForDetailPanel(timeline, element) {
>    const button = element.querySelector(".animation-detail-header button");
>    const onclosed = timeline.once("animation-detail-closed");
>    EventUtils.sendMouseEvent({type: "click"}, button, element.ownerDocument.defaultView);
> -  return yield onclosed;
> +  return await onclosed;

Error: Redundant use of `await` on a return value. [eslint: no-return-await]

::: devtools/client/animationinspector/test/head.js:92
(Diff revision 1)
>             and animations of its subtree are properly displayed.
>   */
>  var selectNodeAndWaitForAnimations = async function(data, inspector, reason = "test") {
>      // We want to make sure the rest of the test waits for the animations to
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:94
(Diff revision 1)
>  var selectNodeAndWaitForAnimations = async function(data, inspector, reason = "test") {
>      // We want to make sure the rest of the test waits for the animations to
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:96
(Diff revision 1)
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
>      await selectNode(data, inspector, reason);

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:98
(Diff revision 1)
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
>      await selectNode(data, inspector, reason);
>  
>      await onUiUpdated;

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:99
(Diff revision 1)
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
>      await selectNode(data, inspector, reason);
>  
>      await onUiUpdated;
>      if (AnimationsController.animationPlayers.length !== 0) {

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:103
(Diff revision 1)
>      await onUiUpdated;
>      if (AnimationsController.animationPlayers.length !== 0) {
>        await waitForAnimationTimelineRendering(AnimationsPanel);
>        await waitForAllAnimationTargets(AnimationsPanel);
>      }
>    };

Error: Expected indentation of 0 spaces but found 2. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:403
(Diff revision 1)
>    EventUtils.sendMouseEvent({ type: "mousedown", clientX: clientX },
>                              header, header.ownerDocument.defaultView);
>    info(`Click at (${ clientX }, 0) on timeline header`);
>    EventUtils.sendMouseEvent({ type: "mouseup", clientX: clientX }, header,
>                              header.ownerDocument.defaultView);
> -  return yield onTimelineDataChanged;
> +  return await onTimelineDataChanged;

Error: Redundant use of `await` on a return value. [eslint: no-return-await]

::: devtools/client/animationinspector/test/head.js:450
(Diff revision 1)
>      // Move the mouse pointer a little since scrubber element may be at the point.
>      x += timeBlockBounds.width / 4;
>    }
>    EventUtils.synthesizeMouse(timeBlock, x, y, {}, timeBlock.ownerDocument.defaultView);
>  
> -  return yield onSelectionChanged;
> +  return await onSelectionChanged;

Error: Redundant use of `await` on a return value. [eslint: no-return-await]

Comment hidden (spam)

Comment on attachment 8960632 [details]
Bug 1443480 - Put spaces before parentheses in "async function()" pattern in devtools/client/animationinspector.

https://reviewboard.mozilla.org/r/229408/#review235136


Code analysis found 73 defects in this patch (only the first 30 are reported here):
 - 73 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/animationinspector/animation-controller.js:33
(Diff revision 1)
>  
>  /**
>   * Startup the animationinspector controller and view, called by the sidebar
>   * widget when loading/unloading the iframe into the tab.
>   */
> -var startup = async function(inspector) {
> +var startup = async function (inspector) {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/animation-controller.js:54
(Diff revision 1)
>  
>  /**
>   * Shutdown the animationinspector controller and view, called by the sidebar
>   * widget when loading/unloading the iframe into the tab.
>   */
> -var shutdown = async function() {
> +var shutdown = async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/animation-controller.js:77
(Diff revision 1)
>   * Get all the server-side capabilities (traits) so the UI knows whether or not
>   * features should be enabled/disabled.
>   * @param {Target} target The current toolbox target.
>   * @return {Object} An object with boolean properties.
>   */
> -var getServerTraits = async function(target) {
> +var getServerTraits = async function (target) {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_animated_properties_displayed.js:34
(Diff revision 1)
>    "background-position-y",
>    "background-repeat",
>    "background-size"
>  ].sort();
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_animated_properties_for_delayed_starttime_animations.js:11
(Diff revision 1)
>  
>  // Test for animations that have different starting time.
>  // We should check progress indicator working well even if the start time is not zero.
>  // Also, check that there is no duplication display.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_animated_properties_path.js:335
(Diff revision 1)
>        ]
>      }
>    }
>  ];
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_animated_properties_progress_indicator.js:11
(Diff revision 1)
>  
>  // Test progress indicator in animated properties.
>  // Since this indicator works with the timeline, after selecting each animation,
>  // click the timeline header to change the current time and check the change.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_click_selects_animation.js:10
(Diff revision 1)
>  "use strict";
>  
>  // Check that animations displayed in the timeline can be selected by clicking
>  // them, and that this emits the right events and adds the right classes.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_controller_exposes_document_currentTime.js:10
(Diff revision 1)
>  "use strict";
>  
>  // Test that the controller provides the document.timeline currentTime (at least
>  // the last known version since new animations were added).
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_detail_displayed.js:19
(Diff revision 1)
>  // 6. Stay selected animation even if refresh all UI.
>  // 7. Close the animation-detail element again and click selected animation again.
>  
>  requestLongerTimeout(5);
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_detail_displayed.js:84
(Diff revision 1)
>   */
>  async function clickCloseButtonForDetailPanel(timeline, element) {
>    const button = element.querySelector(".animation-detail-header button");
>    const onclosed = timeline.once("animation-detail-closed");
>    EventUtils.sendMouseEvent({type: "click"}, button, element.ownerDocument.defaultView);
>    return await onclosed;

Error: Redundant use of `await` on a return value. [eslint: no-return-await]

::: devtools/client/animationinspector/test/browser_animation_detail_easings.js:51
(Diff revision 1)
>        expectedValues: ["ease", "ease"],
>      }
>    },
>  };
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_empty_on_invalid_nodes.js:10
(Diff revision 1)
>  
>  requestLongerTimeout(2);
>  
>  // Test that the panel shows no animation data for invalid or not animated nodes
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_keyframe_markers.js:24
(Diff revision 1)
>    "height",
>    "transform",
>    "width"
>  ];
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_mutations_with_same_names.js:12
(Diff revision 1)
>  // Check that when animations are added later (through animation mutations) and
>  // if these animations have the same names, then all of them are still being
>  // displayed (which should be true as long as these animations apply to
>  // different nodes).
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_panel_exists.js:9
(Diff revision 1)
>  
>  "use strict";
>  
>  // Test that the animation panel sidebar exists
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_participate_in_inspector_update.js:13
(Diff revision 1)
>  
>  // Test that the update of the animation panel participate in the
>  // inspector-updated event. This means that the test verifies that the
>  // inspector-updated event is emitted *after* the animation panel is ready.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_playerFronts_are_refreshed.js:12
(Diff revision 1)
>  requestLongerTimeout(2);
>  
>  // Check that the AnimationPlayerFront objects lifecycle is managed by the
>  // AnimationController.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_playerWidgets_appear_on_panel_init.js:12
(Diff revision 1)
>  // Test that player widgets are displayed right when the animation panel is
>  // initialized, if the selected node (<body> by default) is animated.
>  
>  const { ANIMATION_TYPES } = require("devtools/server/actors/animation");
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_playerWidgets_target_nodes.js:11
(Diff revision 1)
>  
>  requestLongerTimeout(2);
>  
>  // Test that player widgets display information about target nodes
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_pseudo_elements.js:9
(Diff revision 1)
>  
>  "use strict";
>  
>  // Test that animated pseudo-elements do show in the timeline.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_refresh_on_added_animation.js:11
(Diff revision 1)
>  
>  requestLongerTimeout(2);
>  
>  // Test that the panel content refreshes when new animations are added.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_refresh_on_removed_animation.js:11
(Diff revision 1)
>  
>  requestLongerTimeout(2);
>  
>  // Test that the panel content refreshes when animations are removed.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_refresh_when_active.js:11
(Diff revision 1)
>  
>  requestLongerTimeout(2);
>  
>  // Test that the panel only refreshes when it is visible in the sidebar.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_refresh_when_active_after_mutations.js:17
(Diff revision 1)
>                                        { x: 49999, y: 0.0 },
>                                        { x: 50000, y: 0.5 },
>                                        { x: 99999, y: 0.5 },
>                                        { x: 100000, y: 0 }];
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_running_on_compositor.js:12
(Diff revision 1)
>  requestLongerTimeout(2);
>  
>  // Test that when animations displayed in the timeline are running on the
>  // compositor, they get a special icon and information in the tooltip.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_same_nb_of_playerWidgets_and_playerFronts.js:12
(Diff revision 1)
>  requestLongerTimeout(2);
>  
>  // Check that when playerFronts are updated, the same number of playerWidgets
>  // are created in the panel.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_shows_player_on_valid_node.js:12
(Diff revision 1)
>  requestLongerTimeout(2);
>  
>  // Test that the panel shows an animation player when an animated node is
>  // selected.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_spacebar_toggles_animations.js:13
(Diff revision 1)
>  // when a node with no animation is selected.
>  // This test doesn't need to test if animations actually pause/resume
>  // because there's an other test that does this :
>  // browser_animation_toggle_button_toggles_animation.js
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_spacebar_toggles_node_animations.js:16
(Diff revision 1)
>  // is selected, animations will be displayed in the timeline, so the timeline
>  // play/resume button will be displayed
>  
>  requestLongerTimeout(2);
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_summarygraph_for_multiple_easings.js:146
(Diff revision 1)
>        ]
>      ]
>    },
>  };
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_target_highlight_select.js:12
(Diff revision 1)
>  requestLongerTimeout(2);
>  
>  // Test that the DOM element targets displayed in animation player widgets can
>  // be used to highlight elements in the DOM and select them in the inspector.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_target_highlighter_lock.js:12
(Diff revision 1)
>  requestLongerTimeout(2);
>  
>  // Test that the DOM element targets displayed in animation player widgets can
>  // be used to highlight elements in the DOM and select them in the inspector.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_add_animation.js:10
(Diff revision 1)
>  "use strict";
>  
>  // Test re-used animation element since we re-use existent animation element
>  // for the render performance.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_currentTime.js:14
(Diff revision 1)
>  
>  // Check that the timeline toolbar displays the current time, and that it
>  // changes when animations are playing, gets back to 0 when animations are
>  // rewound, and stops when animations are paused.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_header.js:17
(Diff revision 1)
>  
>  // Should be kept in sync with TIME_GRADUATION_MIN_SPACING in
>  // animation-timeline.js
>  const TIME_GRADUATION_MIN_SPACING = 40;
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_iterationStart.js:9
(Diff revision 1)
>  
>  "use strict";
>  
>  // Check that the iteration start is displayed correctly in time blocks.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_pause_button_01.js:13
(Diff revision 1)
>  
>  // Check that the timeline toolbar contains a pause button and that this pause button can
>  // be clicked. Check that when it is, the button changes state and the scrubber stops and
>  // resumes.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_pause_button_02.js:15
(Diff revision 1)
>    "resource://gre/modules/Preferences.jsm");
>  
>  // Checks that the play/pause button goes to the right state when the scrubber has reached
>  // the end of the timeline but there are infinite animations playing.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_pause_button_03.js:15
(Diff revision 1)
>  // reached the end of the timeline: continues to be in playing mode for infinite
>  // animations, goes to paused mode otherwise.
>  // And test that clicking the button once the scrubber has reached the end of
>  // the timeline does the right thing.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_rate_selector.js:15
(Diff revision 1)
>  // it can be used to change the playback rate of animations in the timeline.
>  // Also check that it displays the rate of the current animations in case they
>  // all have the same rate, or that it displays the empty value in case they
>  // have mixed rates.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_rewind_button.js:16
(Diff revision 1)
>  // clicked. Check that when it is, the current animations displayed in the
>  // timeline get their playstates changed to paused, and their currentTimes
>  // reset to 0, and that the scrubber stops moving and is positioned to the
>  // start.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_scrubber_exists.js:11
(Diff revision 1)
>  
>  requestLongerTimeout(2);
>  
>  // Check that the timeline does have a scrubber element.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_scrubber_movable.js:15
(Diff revision 1)
>  // in the header area.
>  // Also check that doing so changes the timeline's play/pause button to paused
>  // state.
>  // Finally, also check that the scrubber can be moved using the scrubber handle.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_scrubber_moves.js:15
(Diff revision 1)
>  // Check that the scrubber in the timeline moves when animations are playing.
>  // The animations in the test page last for a very long time, so the test just
>  // measures the position of the scrubber once, then waits for some time to pass
>  // and measures its position again.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_setCurrentTime.js:21
(Diff revision 1)
>  // So we modify setCurrentTime method since
>  // AnimationInspector should re-produce same as original animation.
>  // In these tests,
>  // we confirm the behavior of setCurrentTime by delay and endDelay.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_short_duration.js:11
(Diff revision 1)
>  
>  requestLongerTimeout(2);
>  
>  // Test short duration (e.g. 1ms) animation.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_shows_delay.js:14
(Diff revision 1)
>  // Check that animation delay is visualized in the timeline when the animation
>  // is delayed.
>  // Also check that negative delays do not overflow the UI, and are shown like
>  // positive delays.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_shows_endDelay.js:14
(Diff revision 1)
>  // Check that animation endDelay is visualized in the timeline when the
>  // animation is delayed.
>  // Also check that negative endDelays do not overflow the UI, and are shown
>  // like positive endDelays.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_shows_iterations.js:12
(Diff revision 1)
>  requestLongerTimeout(2);
>  
>  // Check that the timeline is displays as many iteration elements as there are
>  // iterations in an animation.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_shows_name_label.js:11
(Diff revision 1)
>  
>  requestLongerTimeout(2);
>  
>  // Check the text content and width of name label.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_shows_time_info.js:12
(Diff revision 1)
>  requestLongerTimeout(2);
>  
>  // Check that the timeline displays animations' duration, delay iteration
>  // counts and iteration start in tooltips.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_takes_rate_into_account.js:14
(Diff revision 1)
>  // Indeed, the header in the timeline UI always shows the unaltered time,
>  // because there might be multiple animations displayed at the same time, some
>  // of which may have a different rate than others. Those that have had their
>  // rate changed have a delay = delay/rate and a duration = duration/rate.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_timeline_ui.js:11
(Diff revision 1)
>  
>  requestLongerTimeout(2);
>  
>  // Check that the timeline contains the right elements.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_toggle_button_resets_on_navigate.js:11
(Diff revision 1)
>  
>  requestLongerTimeout(2);
>  
>  // Test that a page navigation resets the state of the global toggle button.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_toggle_button_toggles_animations.js:14
(Diff revision 1)
>  // Test that the main toggle button actually toggles animations.
>  // This test doesn't need to be extra careful about checking that *all*
>  // animations have been paused (including inside iframes) because there's an
>  // actor test in /devtools/server/tests/browser/ that does this.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_toolbar_exists.js:14
(Diff revision 1)
>  // Test that the animation panel has a top toolbar that contains the play/pause
>  // button and that is displayed at all times.
>  // Also test that this toolbar gets replaced by the timeline toolbar when there
>  // are animations to be displayed.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/browser_animation_ui_updates_when_animation_data_changes.js:12
(Diff revision 1)
>  requestLongerTimeout(2);
>  
>  // Verify that if the animation's duration, iterations or delay change in
>  // content, then the widget reflects the changes.
>  
> -add_task(async function() {
> +add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:20
(Diff revision 1)
>  const TAB_NAME = "animationinspector";
>  const ANIMATION_L10N =
>    new LocalizationHelper("devtools/client/locales/animationinspector.properties");
>  
>  // Auto clean-up when a test ends
> -registerCleanupFunction(async function() {
> +registerCleanupFunction(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:89
(Diff revision 1)
>   *        Defaults to "test" which instructs the inspector not
>   *        to highlight the node upon selection
>   * @return {Promise} Resolves when the inspector is updated with the new node
>             and animations of its subtree are properly displayed.
>   */
> -var selectNodeAndWaitForAnimations = async function(data, inspector, reason = "test") {
> +var selectNodeAndWaitForAnimations = async function (data, inspector, reason = "test") {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:92
(Diff revision 1)
>             and animations of its subtree are properly displayed.
>   */
> -var selectNodeAndWaitForAnimations = async function(data, inspector, reason = "test") {
> +var selectNodeAndWaitForAnimations = async function (data, inspector, reason = "test") {
>      // We want to make sure the rest of the test waits for the animations to
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:94
(Diff revision 1)
> -var selectNodeAndWaitForAnimations = async function(data, inspector, reason = "test") {
> +var selectNodeAndWaitForAnimations = async function (data, inspector, reason = "test") {
>      // We want to make sure the rest of the test waits for the animations to
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:96
(Diff revision 1)
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
>      await selectNode(data, inspector, reason);

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:98
(Diff revision 1)
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
>      await selectNode(data, inspector, reason);
>  
>      await onUiUpdated;

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:99
(Diff revision 1)
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
>      await selectNode(data, inspector, reason);
>  
>      await onUiUpdated;
>      if (AnimationsController.animationPlayers.length !== 0) {

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:103
(Diff revision 1)
>      await onUiUpdated;
>      if (AnimationsController.animationPlayers.length !== 0) {
>        await waitForAnimationTimelineRendering(AnimationsPanel);
>        await waitForAllAnimationTargets(AnimationsPanel);
>      }
>    };

Error: Expected indentation of 0 spaces but found 2. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:127
(Diff revision 1)
>   * sidebar to be ready. Returns a promise once these are completed.
>   *
>   * @param {InspectorPanel} inspector
>   * @return {Promise}
>   */
> -var waitForAnimationInspectorReady = async function(inspector) {
> +var waitForAnimationInspectorReady = async function (inspector) {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:147
(Diff revision 1)
>  /**
>   * Open the toolbox, with the inspector tool visible and the animationinspector
>   * sidebar selected.
>   * @return a promise that resolves when the inspector is ready.
>   */
> -var openAnimationInspector = async function() {
> +var openAnimationInspector = async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:181
(Diff revision 1)
>  
>  /**
>   * Close the toolbox.
>   * @return a promise that resolves when the toolbox has closed.
>   */
> -var closeAnimationInspector = async function() {
> +var closeAnimationInspector = async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:234
(Diff revision 1)
>  }
>  
>  /**
>   * Get the current playState of an animation player on a given node.
>   */
> -var getAnimationPlayerState = async function(selector,
> +var getAnimationPlayerState = async function (selector,

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:258
(Diff revision 1)
>   * This method should be called after "animation-timeline-rendering-completed" is emitted,
>   * since we get all the AnimationTargetNode instances using getAnimationTargetNodes().
>   * @param {AnimationsPanel} panel
>   * @return {Array} all AnimationTargetNode instances
>   */
> -var waitForAllAnimationTargets = async function(panel) {
> +var waitForAllAnimationTargets = async function (panel) {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:403
(Diff revision 1)
>    EventUtils.sendMouseEvent({ type: "mousedown", clientX: clientX },
>                              header, header.ownerDocument.defaultView);
>    info(`Click at (${ clientX }, 0) on timeline header`);
>    EventUtils.sendMouseEvent({ type: "mouseup", clientX: clientX }, header,
>                              header.ownerDocument.defaultView);
>    return await onTimelineDataChanged;

Error: Redundant use of `await` on a return value. [eslint: no-return-await]

::: devtools/client/animationinspector/test/head.js:450
(Diff revision 1)
>      // Move the mouse pointer a little since scrubber element may be at the point.
>      x += timeBlockBounds.width / 4;
>    }
>    EventUtils.synthesizeMouse(timeBlock, x, y, {}, timeBlock.ownerDocument.defaultView);
>  
>    return await onSelectionChanged;

Error: Redundant use of `await` on a return value. [eslint: no-return-await]

Comment hidden (spam)

Comment on attachment 8960633 [details]
Bug 1443480 - Get rid of the now useless require("devtools/shared/task").

https://reviewboard.mozilla.org/r/229410/#review235138


Code analysis found 4 defects in this patch:
 - 4 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/animationinspector/animation-controller.js:32
(Diff revision 1)
>  
>  /**
>   * Startup the animationinspector controller and view, called by the sidebar
>   * widget when loading/unloading the iframe into the tab.
>   */
>  var startup = async function (inspector) {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/animation-controller.js:53
(Diff revision 1)
>  
>  /**
>   * Shutdown the animationinspector controller and view, called by the sidebar
>   * widget when loading/unloading the iframe into the tab.
>   */
>  var shutdown = async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/animation-controller.js:76
(Diff revision 1)
>   * Get all the server-side capabilities (traits) so the UI knows whether or not
>   * features should be enabled/disabled.
>   * @param {Target} target The current toolbox target.
>   * @return {Object} An object with boolean properties.
>   */
>  var getServerTraits = async function (target) {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/components/animation-details.js:93
(Diff revision 1)
>     *                  e.g. { "background-color": "color", }
>     *                         "opacity": "float", ... }
>     */
>    async getAnimationTypes(propertyNames) {
>      if (this.serverTraits.hasGetAnimationTypes) {
>        return await this.animation.getAnimationTypes(propertyNames);

Error: Redundant use of `await` on a return value. [eslint: no-return-await]

Comment hidden (spam)

Comment on attachment 8960634 [details]
Bug 1443480 - manual eslint fixes.

https://reviewboard.mozilla.org/r/229412/#review235142


Code analysis found 8 defects in this patch:
 - 8 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/animationinspector/test/browser_animation_detail_displayed.js:19
(Diff revision 1)
>  // 6. Stay selected animation even if refresh all UI.
>  // 7. Close the animation-detail element again and click selected animation again.
>  
>  requestLongerTimeout(5);
>  
>  add_task(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:20
(Diff revision 1)
>  const TAB_NAME = "animationinspector";
>  const ANIMATION_L10N =
>    new LocalizationHelper("devtools/client/locales/animationinspector.properties");
>  
>  // Auto clean-up when a test ends
>  registerCleanupFunction(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:89
(Diff revision 1)
>   *        Defaults to "test" which instructs the inspector not
>   *        to highlight the node upon selection
>   * @return {Promise} Resolves when the inspector is updated with the new node
>             and animations of its subtree are properly displayed.
>   */
>  var selectNodeAndWaitForAnimations = async function (data, inspector, reason = "test") {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:127
(Diff revision 1)
>   * sidebar to be ready. Returns a promise once these are completed.
>   *
>   * @param {InspectorPanel} inspector
>   * @return {Promise}
>   */
>  var waitForAnimationInspectorReady = async function (inspector) {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:147
(Diff revision 1)
>  /**
>   * Open the toolbox, with the inspector tool visible and the animationinspector
>   * sidebar selected.
>   * @return a promise that resolves when the inspector is ready.
>   */
>  var openAnimationInspector = async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:181
(Diff revision 1)
>  
>  /**
>   * Close the toolbox.
>   * @return a promise that resolves when the toolbox has closed.
>   */
>  var closeAnimationInspector = async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:234
(Diff revision 1)
>  }
>  
>  /**
>   * Get the current playState of an animation player on a given node.
>   */
>  var getAnimationPlayerState = async function (selector,

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:258
(Diff revision 1)
>   * This method should be called after "animation-timeline-rendering-completed" is emitted,
>   * since we get all the AnimationTargetNode instances using getAnimationTargetNodes().
>   * @param {AnimationsPanel} panel
>   * @return {Array} all AnimationTargetNode instances
>   */
>  var waitForAllAnimationTargets = async function (panel) {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

Comment hidden (spam)

Comment on attachment 8960635 [details]
Bug 1443480 - Fix browser_animation_timeline_rate_selector failure.

https://reviewboard.mozilla.org/r/229414/#review235144


Code analysis found 7 defects in this patch:
 - 7 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/animationinspector/test/head.js:20
(Diff revision 1)
>  const TAB_NAME = "animationinspector";
>  const ANIMATION_L10N =
>    new LocalizationHelper("devtools/client/locales/animationinspector.properties");
>  
>  // Auto clean-up when a test ends
>  registerCleanupFunction(async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:89
(Diff revision 1)
>   *        Defaults to "test" which instructs the inspector not
>   *        to highlight the node upon selection
>   * @return {Promise} Resolves when the inspector is updated with the new node
>             and animations of its subtree are properly displayed.
>   */
>  var selectNodeAndWaitForAnimations = async function (data, inspector, reason = "test") {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:127
(Diff revision 1)
>   * sidebar to be ready. Returns a promise once these are completed.
>   *
>   * @param {InspectorPanel} inspector
>   * @return {Promise}
>   */
>  var waitForAnimationInspectorReady = async function (inspector) {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:147
(Diff revision 1)
>  /**
>   * Open the toolbox, with the inspector tool visible and the animationinspector
>   * sidebar selected.
>   * @return a promise that resolves when the inspector is ready.
>   */
>  var openAnimationInspector = async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:181
(Diff revision 1)
>  
>  /**
>   * Close the toolbox.
>   * @return a promise that resolves when the toolbox has closed.
>   */
>  var closeAnimationInspector = async function () {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:234
(Diff revision 1)
>  }
>  
>  /**
>   * Get the current playState of an animation player on a given node.
>   */
>  var getAnimationPlayerState = async function (selector,

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

::: devtools/client/animationinspector/test/head.js:258
(Diff revision 1)
>   * This method should be called after "animation-timeline-rendering-completed" is emitted,
>   * since we get all the AnimationTargetNode instances using getAnimationTargetNodes().
>   * @param {AnimationsPanel} panel
>   * @return {Array} all AnimationTargetNode instances
>   */
>  var waitForAllAnimationTargets = async function (panel) {

Error: Unexpected space before function parentheses. [eslint: space-before-function-paren]

J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)

Comment 15

•

6 years ago

mozreview-review

Comment on attachment 8960630 [details]
Bug 1443480 - Convert Task.jsm to async/await in devtools/client/animationinspector.

https://reviewboard.mozilla.org/r/229404/#review235240

Thanks for working on this! :)

Attachment #8960630 - Flags: review?(jryans) → review+

J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)

Comment 16

•

6 years ago

mozreview-review

Comment on attachment 8960631 [details]
Bug 1443480 - Convert generators to async functions in devtools/client/animationinspector

https://reviewboard.mozilla.org/r/229406/#review235242

Attachment #8960631 - Flags: review?(jryans) → review+

J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)

Comment 17

•

6 years ago

mozreview-review

Comment on attachment 8960632 [details]
Bug 1443480 - Put spaces before parentheses in "async function()" pattern in devtools/client/animationinspector.

https://reviewboard.mozilla.org/r/229408/#review235244

I think you need to rebase...?  We changed the spacing rules while you were on PTO in bug 1443081.

Attachment #8960632 - Flags: review?(jryans) → review-

J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)

Comment 18

•

6 years ago

mozreview-review

Comment on attachment 8960633 [details]
Bug 1443480 - Get rid of the now useless require("devtools/shared/task").

https://reviewboard.mozilla.org/r/229410/#review235246

Attachment #8960633 - Flags: review?(jryans) → review+

J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)

Comment 19

•

6 years ago

mozreview-review

Comment on attachment 8960634 [details]
Bug 1443480 - manual eslint fixes.

https://reviewboard.mozilla.org/r/229412/#review235248

Attachment #8960634 - Flags: review?(jryans) → review+

J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)

Comment 20

•

6 years ago

mozreview-review

Comment on attachment 8960635 [details]
Bug 1443480 - Fix browser_animation_timeline_rate_selector failure.

https://reviewboard.mozilla.org/r/229414/#review235250

Great, thanks again for your work here! :)

Attachment #8960635 - Flags: review?(jryans) → review+

Comment hidden (mozreview-request)

Comment on attachment 8960629 [details]
Bug 1443480 - xpcshell script used to convert files, coming from bug 1353542

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229402/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8960630 [details]
Bug 1443480 - Convert Task.jsm to async/await in devtools/client/animationinspector.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229404/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8960631 [details]
Bug 1443480 - Convert generators to async functions in devtools/client/animationinspector

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229406/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8960633 [details]
Bug 1443480 - Get rid of the now useless require("devtools/shared/task").

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229410/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8960634 [details]
Bug 1443480 - manual eslint fixes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229412/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8960635 [details]
Bug 1443480 - Fix browser_animation_timeline_rate_selector failure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229414/diff/1-2/

Alexandre Poirot [:ochameau]

Assignee

Updated

•

6 years ago

Attachment #8960632 - Attachment is obsolete: true

Comment hidden (obsolete)

Comment on attachment 8960630 [details]
Bug 1443480 - Convert Task.jsm to async/await in devtools/client/animationinspector.

https://reviewboard.mozilla.org/r/229404/#review235296


Code analysis found 10 defects in this patch:
 - 10 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/animationinspector/components/animation-details.js:9
(Diff revision 2)
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  "use strict";
>  
>  const {Task} = require("devtools/shared/task");

Error: 'task' is assigned a value but never used. [eslint: no-unused-vars]

::: devtools/client/animationinspector/components/animation-details.js:94
(Diff revision 2)
>     *                  e.g. { "background-color": "color", }
>     *                         "opacity": "float", ... }
>     */
> -  getAnimationTypes: Task.async(function* (propertyNames) {
> +  async getAnimationTypes(propertyNames) {
>      if (this.serverTraits.hasGetAnimationTypes) {
> -      return yield this.animation.getAnimationTypes(propertyNames);
> +      return await this.animation.getAnimationTypes(propertyNames);

Error: Redundant use of `await` on a return value. [eslint: no-return-await]

::: devtools/client/animationinspector/components/animation-target-node.js:9
(Diff revision 2)
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  "use strict";
>  
>  const {Task} = require("devtools/shared/task");

Error: 'task' is assigned a value but never used. [eslint: no-unused-vars]

::: devtools/client/animationinspector/components/animation-timeline.js:9
(Diff revision 2)
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  "use strict";
>  
>  const { Task } = require("devtools/shared/task");

Error: 'task' is assigned a value but never used. [eslint: no-unused-vars]

::: devtools/client/animationinspector/test/head.js:92
(Diff revision 2)
>   */
> -var selectNodeAndWaitForAnimations = Task.async(
> +var selectNodeAndWaitForAnimations = async function(data, inspector, reason = "test") {
> -  function* (data, inspector, reason = "test") {
>      // We want to make sure the rest of the test waits for the animations to
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:94
(Diff revision 2)
> -  function* (data, inspector, reason = "test") {
>      // We want to make sure the rest of the test waits for the animations to
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:96
(Diff revision 2)
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
> -    yield selectNode(data, inspector, reason);
> +    await selectNode(data, inspector, reason);

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:98
(Diff revision 2)
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
> -    yield selectNode(data, inspector, reason);
> +    await selectNode(data, inspector, reason);
>  
> -    yield onUiUpdated;
> +    await onUiUpdated;

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:99
(Diff revision 2)
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
> -    yield selectNode(data, inspector, reason);
> +    await selectNode(data, inspector, reason);
>  
> -    yield onUiUpdated;
> +    await onUiUpdated;
>      if (AnimationsController.animationPlayers.length !== 0) {

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:103
(Diff revision 2)
> -    yield onUiUpdated;
> +    await onUiUpdated;
>      if (AnimationsController.animationPlayers.length !== 0) {
> -      yield waitForAnimationTimelineRendering(AnimationsPanel);
> -      yield waitForAllAnimationTargets(AnimationsPanel);
> +      await waitForAnimationTimelineRendering(AnimationsPanel);
> +      await waitForAllAnimationTargets(AnimationsPanel);
>      }
> -  }
> +  };

Error: Expected indentation of 0 spaces but found 2. [eslint: indent-legacy]

Comment hidden (obsolete)

Comment on attachment 8960631 [details]
Bug 1443480 - Convert generators to async functions in devtools/client/animationinspector

https://reviewboard.mozilla.org/r/229406/#review235298


Code analysis found 9 defects in this patch:
 - 9 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/animationinspector/test/browser_animation_detail_displayed.js:84
(Diff revision 2)
>   */
> -function* clickCloseButtonForDetailPanel(timeline, element) {
> +async function clickCloseButtonForDetailPanel(timeline, element) {
>    const button = element.querySelector(".animation-detail-header button");
>    const onclosed = timeline.once("animation-detail-closed");
>    EventUtils.sendMouseEvent({type: "click"}, button, element.ownerDocument.defaultView);
> -  return yield onclosed;
> +  return await onclosed;

Error: Redundant use of `await` on a return value. [eslint: no-return-await]

::: devtools/client/animationinspector/test/head.js:92
(Diff revision 2)
>             and animations of its subtree are properly displayed.
>   */
>  var selectNodeAndWaitForAnimations = async function(data, inspector, reason = "test") {
>      // We want to make sure the rest of the test waits for the animations to
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:94
(Diff revision 2)
>  var selectNodeAndWaitForAnimations = async function(data, inspector, reason = "test") {
>      // We want to make sure the rest of the test waits for the animations to
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:96
(Diff revision 2)
>      // be properly displayed (wait for all target DOM nodes to be previewed).
>      let {AnimationsController, AnimationsPanel} =
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
>      await selectNode(data, inspector, reason);

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:98
(Diff revision 2)
>        inspector.sidebar.getWindowForTab(TAB_NAME);
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
>      await selectNode(data, inspector, reason);
>  
>      await onUiUpdated;

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:99
(Diff revision 2)
>      let onUiUpdated = AnimationsPanel.once(AnimationsPanel.UI_UPDATED_EVENT);
>  
>      await selectNode(data, inspector, reason);
>  
>      await onUiUpdated;
>      if (AnimationsController.animationPlayers.length !== 0) {

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:103
(Diff revision 2)
>      await onUiUpdated;
>      if (AnimationsController.animationPlayers.length !== 0) {
>        await waitForAnimationTimelineRendering(AnimationsPanel);
>        await waitForAllAnimationTargets(AnimationsPanel);
>      }
>    };

Error: Expected indentation of 0 spaces but found 2. [eslint: indent-legacy]

::: devtools/client/animationinspector/test/head.js:403
(Diff revision 2)
>    EventUtils.sendMouseEvent({ type: "mousedown", clientX: clientX },
>                              header, header.ownerDocument.defaultView);
>    info(`Click at (${ clientX }, 0) on timeline header`);
>    EventUtils.sendMouseEvent({ type: "mouseup", clientX: clientX }, header,
>                              header.ownerDocument.defaultView);
> -  return yield onTimelineDataChanged;
> +  return await onTimelineDataChanged;

Error: Redundant use of `await` on a return value. [eslint: no-return-await]

::: devtools/client/animationinspector/test/head.js:450
(Diff revision 2)
>      // Move the mouse pointer a little since scrubber element may be at the point.
>      x += timeBlockBounds.width / 4;
>    }
>    EventUtils.synthesizeMouse(timeBlock, x, y, {}, timeBlock.ownerDocument.defaultView);
>  
> -  return yield onSelectionChanged;
> +  return await onSelectionChanged;

Error: Redundant use of `await` on a return value. [eslint: no-return-await]

Comment hidden (obsolete)

Comment on attachment 8960633 [details]
Bug 1443480 - Get rid of the now useless require("devtools/shared/task").

https://reviewboard.mozilla.org/r/229410/#review235300


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/animationinspector/components/animation-details.js:93
(Diff revision 2)
>     *                  e.g. { "background-color": "color", }
>     *                         "opacity": "float", ... }
>     */
>    async getAnimationTypes(propertyNames) {
>      if (this.serverTraits.hasGetAnimationTypes) {
>        return await this.animation.getAnimationTypes(propertyNames);

Error: Redundant use of `await` on a return value. [eslint: no-return-await]

Comment hidden (mozreview-request)

Comment on attachment 8960630 [details]
Bug 1443480 - Convert Task.jsm to async/await in devtools/client/animationinspector.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229404/diff/2-3/

Alexandre Poirot [:ochameau]

Assignee

Updated

•

6 years ago

Attachment #8960629 - Attachment is obsolete: true

Alexandre Poirot [:ochameau]

Assignee

Updated

•

6 years ago

Attachment #8960631 - Attachment is obsolete: true

Alexandre Poirot [:ochameau]

Assignee

Updated

•

6 years ago

Attachment #8960633 - Attachment is obsolete: true

Alexandre Poirot [:ochameau]

Assignee

Updated

•

6 years ago

Attachment #8960634 - Attachment is obsolete: true

Alexandre Poirot [:ochameau]

Assignee

Updated

•

6 years ago

Attachment #8960635 - Attachment is obsolete: true

Pulsebot

Comment 31

•

6 years ago

Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce36cc4bb58a
Convert Task.jsm to async/await in devtools/client/animationinspector. r=jryans

Arthur Iakab [arthur_iakab]

Comment 32

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/ce36cc4bb58a

Status: NEW → RESOLVED

Closed: 6 years ago

status-firefox61: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 61

BMO Automation

Updated

•

6 years ago

Product: Firefox → DevTools

Bug 1443480 - xpcshell script used to convert files, coming from bug 1353542 6 years ago Alexandre Poirot [:ochameau] 59 bytes, text/x-review-board-request		Details
Bug 1443480 - Convert Task.jsm to async/await in devtools/client/animationinspector. 6 years ago Alexandre Poirot [:ochameau] 59 bytes, text/x-review-board-request	jryans : review+	Details
Bug 1443480 - Convert generators to async functions in devtools/client/animationinspector 6 years ago Alexandre Poirot [:ochameau] 59 bytes, text/x-review-board-request	jryans : review+	Details
Bug 1443480 - Put spaces before parentheses in "async function()" pattern in devtools/client/animationinspector. 6 years ago Alexandre Poirot [:ochameau] 59 bytes, text/x-review-board-request	jryans : review-	Details
Bug 1443480 - Get rid of the now useless require("devtools/shared/task"). 6 years ago Alexandre Poirot [:ochameau] 59 bytes, text/x-review-board-request	jryans : review+	Details
Bug 1443480 - manual eslint fixes. 6 years ago Alexandre Poirot [:ochameau] 59 bytes, text/x-review-board-request	jryans : review+	Details
Bug 1443480 - Fix browser_animation_timeline_rate_selector failure. 6 years ago Alexandre Poirot [:ochameau] 59 bytes, text/x-review-board-request	jryans : review+	Details