Closed Bug 1443492 Opened 4 years ago Closed 4 years ago

Media queries not quite updated correctly when calling getComputedStyle cross doc.

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(2 files)

Attached file testcase
The test-case passes if you add a explicit layout flush to the parent document after changing the style attribute, or if you use frm.contentWindow.getComputedStyle instead.
This is not a very recent regression it seems.
Comment on attachment 8956447 [details]
Bug 1443492: Flush the document, not the shell, in cross-doc getComputedStyle situations.

https://reviewboard.mozilla.org/r/225346/#review234038

::: testing/web-platform/tests/css/cssom/getComputedStyle-dynamic-subdoc.html:12
(Diff revision 2)
> +<script src=/resources/testharnessreport.js></script>
> +<!--
> +  NOTE: The way this test is written doesn't match the spec, but matches all
> +  implementations, see https://github.com/w3c/csswg-drafts/issues/2403
> +-->
> +<iframe id="frm" style="width: 100px; heigth: 100px"></iframe>

s/heigth/height/
Attachment #8956447 - Flags: review?(dbaron) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cbafe1855cc
Flush the document, not the shell, in cross-doc getComputedStyle situations. r=dbaron
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10079 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
https://hg.mozilla.org/mozilla-central/rev/9cbafe1855cc
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.