1443492 - Media queries not quite updated correctly when calling getComputedStyle cross doc.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Attachment: testcase

The test-case passes if you add a explicit layout flush to the parent document after changing the style attribute, or if you use frm.contentWindow.getComputedStyle instead.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

This is not a very recent regression it seems.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1443492: Flush the document, not the shell, in cross-doc getComputedStyle situations.

We flushed the style of the original doc, but not layout, and thus the iframe
resize wasn't noticed, and the style flush on the child presShell wasn't
sufficient.

Do a style flush on the child document instead, so that it flushes layout on the
parent document too if needed.

Review commit: https://reviewboard.mozilla.org/r/225346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225346/

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8956447 [details]
Bug 1443492: Flush the document, not the shell, in cross-doc getComputedStyle situations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/225346/diff/1-2/

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 8956447 [details]
Bug 1443492: Flush the document, not the shell, in cross-doc getComputedStyle situations.

https://reviewboard.mozilla.org/r/225346/#review234038

::: testing/web-platform/tests/css/cssom/getComputedStyle-dynamic-subdoc.html:12
(Diff revision 2)
> +<script src=/resources/testharnessreport.js></script>
> +<!--
> +  NOTE: The way this test is written doesn't match the spec, but matches all
> +  implementations, see https://github.com/w3c/csswg-drafts/issues/2403
> +-->
> +<iframe id="frm" style="width: 100px; heigth: 100px"></iframe>

s/heigth/height/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cbafe1855cc
Flush the document, not the shell, in cross-doc getComputedStyle situations. r=dbaron

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10079 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/9cbafe1855cc

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged