1443560 - Register telemetry events statically

Status: RESOLVED FIXED

(Firefox :: Normandy Client, enhancement, P3)

Description

[Michael Cooper [:mythmon]]

Normandy currently dynamically registers telemetry events. It does this because it used to be a system add-on that could be updated via go faster. With bug 1436113 landed, we no longer are an add-on, so no longer need dynamic registration.

Comment 2

[Ethan Glasser-Camp (:glasserc)]

Attachment: Bug 1443560: register telemetry events statically

Comment 3

[Ethan Glasser-Camp (:glasserc)]

Attachment: Bug 1443560: Convert checks to examine snapshotted events

Because the mock no longer checks whether the format of events is
correct, check the events that Telemetry actually records, in order to
make sure we conform to the event schema.

Some uses check that no calls were made to the stub. Although this
is technically still valid (because we don't care about the format of
events in this case), convert even these to check events for
consistency.

TelemetryTestUtils.assertEvents doesn't allow us to pass a message,
but most of these messages don't add anything useful and at least one
is just wrong so it's not a big loss.

Depends on D19540

Comment 4

[Ethan Glasser-Camp (:glasserc)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=19e5ddb21adfa18d2221d3ba729fe393f343fb18

Comment 5

[Ethan Glasser-Camp (:glasserc)]

Just to be sure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1413fba90820711a634fc018ab40e05ae5b5fe09

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec979e0f73ce
register telemetry events statically r=Gijs
https://hg.mozilla.org/integration/autoland/rev/48d98388c29c
Convert checks to examine snapshotted events r=Gijs

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/ec979e0f73ce
https://hg.mozilla.org/mozilla-central/rev/48d98388c29c