1443635 - The update binding should be bound to <richlistitem>s instead of custom <update> tags

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

It was documented in bug 1428930 comment 7 but the fix didn't include the change. We'll need to fix this so installed update list can continue be visible in ally view.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1443635 - Remove the custom XUL <update> tag

Restore it to be <richlistitem>s so that nsAccessibilityService can produce
correct accessibles.

Review commit: https://reviewboard.mozilla.org/r/225562/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225562/

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Unfortunately this part of the UI come with no tests :'(

I have manually tested it by setting fake updateCount and |update| properties from |um.getUpdateAt(i);|. I can see the binding got picked up correctly.

Comment 3

[:Paolo Amadini]

Comment on attachment 8956619 [details]
Bug 1443635 - Remove the custom XUL <update> tag

https://reviewboard.mozilla.org/r/225562/#review231590

Looks good! Since there are no automated tests, it will help if you can write down STR so this can be verified manually by the QA team.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

STR on official Nightly:

1. Getting an older Nightly
2. Try to update it
3. After restart, go to about:preferences -> [Show Update History...]
4. Verify the list is still visible.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/749cab14e557
Remove the custom XUL <update> tag r=Paolo

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5a456a57edd
Backed out changeset 749cab14e557 mochitest browser chrome failure at browser_advanced_update.js on a CLOSED TREE

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8956619 [details]
Bug 1443635 - Remove the custom XUL <update> tag

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/225562/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6030763a531d
Remove the custom XUL <update> tag r=Paolo

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/6030763a531d

Comment 10

[Oana Botisan, Desktop QA]

I verified with the steps from comment 4. I used older version of Nightly and updated them to the latest Nightly 61.0a1. I did the same think with beta versions and updated them to beta 60.0b4 on Windows 10x64, Mac OS 10.11 and Ubuntu 16.04.

The list with the updates appeared every time, but I've noticed that on Mac OS and on Ubuntu, even though I used the same profile for the tests, only the last update was listed. Is that an issue? 

And can you please tell me how exactly did this bug manifested? Because I don't know how to reproduce it.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

As long as the list is correctly shown, it should be fine. What this bug is fixing can only be inspected with accessibility technologies.

Comment 12

[Oana Botisan, Desktop QA]

The list was correctly shown. 
According to comment 11 and comment 10 I will mark this bug as verified fixed.