1443648 - no DPI scaling on downloaded or copied shots

Status: RESOLVED FIXED

(Firefox :: Screenshots, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

The latest Screenshots version in Nightly contains a bug where downloaded or copied shots, taken on a screen with high DPI, are saved at blurry, low DPI resolution.

STR:

1. Scale DPI to more than 100%
2. Take a screenshot, then copy or download it.

Expected result:

Screenshot is a faithful representation of the website.

Actual result:

Screenshot is smaller than original, and looks blurry when zoomed.

---

Originally filed as a github issue: https://github.com/mozilla-services/screenshots/issues/4174.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1443648 - Restore high DPI scaling for most downloaded or copied shots;

* Don't overwrite correctly-scaled canvas dimensions when generating a
shot async

* Pass the shot type to downloadShot and copyShot, so that non-fullpage
shots will be correctly scaled. Note that fullpage shots are always low DPI.

Review commit: https://reviewboard.mozilla.org/r/225574/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225574/

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8956625 [details]
Bug 1443648 - Restore high DPI scaling for most downloaded or copied shots;

https://reviewboard.mozilla.org/r/225574/#review231442

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Try run looks good[1]; Wil confirmed with Ritu that this patch is OK to land; triggering autoland.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=56950b0b6026a230c181083677ca9e57a5b64222

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9541861b02d
Restore high DPI scaling for most downloaded or copied shots; r=_6a68

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c9541861b02d