Closed Bug 1443660 Opened 2 years ago Closed 2 years ago

Rename NavigationDelegate.onLoadUri() to onLoadUriRequest()

Categories

(GeckoView :: General, enhancement)

enhancement
Not set

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: snorp, Assigned: snorp)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This is more consistent with other "can I do this" delegate methods.
Comment on attachment 8956634 [details]
Bug 1443660 - Rename NavigationDelegate.onLoadUri() to onLoadRequest()

https://reviewboard.mozilla.org/r/225594/#review231466
Attachment #8956634 - Flags: review?(nchen) → review+
Comment on attachment 8956634 [details]
Bug 1443660 - Rename NavigationDelegate.onLoadUri() to onLoadRequest()

https://reviewboard.mozilla.org/r/225594/#review231840
Attachment #8956634 - Flags: review?(esawin) → review+
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbb5759485fe
Rename NavigationDelegate.onLoadUri() to onLoadRequest() r=jchen,esawin
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e54022a7c56
Rename NavigationDelegate.onLoadUri() to onLoadRequest() r=jchen,esawin
https://hg.mozilla.org/mozilla-central/rev/5e54022a7c56
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Assignee: nobody → snorp
Flags: needinfo?(snorp)
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 60 → mozilla60
You need to log in before you can comment on or make changes to this bug.