Closed Bug 1443682 Opened 2 years ago Closed 2 years ago

Hide the use of OptionalExtensions behind an ifdef

Categories

(Firefox :: Installer, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(1 file)

I'm hiding the use of the OptionalExtesions variable behind an ifdef, as discussed in bug 1441685, which is a result of bug 1427712
Attached patch Fix - v1Splinter Review
Attachment #8956664 - Flags: review?(mhowell)
Comment on attachment 8956664 [details] [diff] [review]
Fix - v1

Review of attachment 8956664 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8956664 - Flags: review?(mhowell) → review+
Pushed by mozilla@kewis.ch:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fc226fbfbd4
Hide the use of OptionalExtensions behind an ifdef. r=mhowell
https://hg.mozilla.org/mozilla-central/rev/7fc226fbfbd4
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Do we need to do anything in TB now, like we could back out
https://hg.mozilla.org/comm-central/rev/df8c22bd2646#l1.12
Flags: needinfo?(philipp)
Yes, pretty sure we could back out anything we did in TB to work around this.
Flags: needinfo?(philipp)
You need to log in before you can comment on or make changes to this bug.