Closed Bug 1443689 Opened 2 years ago Closed 2 years ago
[wpt-sync] Sync PR 9889 - Automatically setting session to None for new session tests
Sync web-platform-tests PR 9889 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/9889 Details from upstream follow. Jim Evans wrote: > Automatically setting session to None for new session tests > > There is an edge case in the current implementation where a "new session" > test can create a new session and expressly close the created session by > calling `end()`, but the next test that is not a "new session" test sees the > "current session" object as not `None`, and failing to create a new > session. This change fixes that issue. If the session is not None and has > a valid session ID, the `end()` method still gets called. If the current > session is not `None`, but has an invalid session ID, it cannot be > terminated any other way, so setting the current session to `None` at that > point is not a negative side effect. Finally, if the current session is > already `None`, setting the variable to `None` again does no harm.
Component: web-platform-tests → geckodriver
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=34cd309d4ba8e1836e67a8af755dab4357891a3d
The following tests were disabled based on stability try push: webdriver/tests/get_window_rect.py
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/907707ea8210 [wpt PR 9889] - Automatically setting session to None for new session tests, a=testonly
You need to log in before you can comment on or make changes to this bug.