Implement customElements.upgrade()

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P3
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: d, Assigned: smaug)

Tracking

unspecified
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Priority: -- → P3
Trying to map rather exactly to what the spec has

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/36f39fa8d59ae8d07c839c0cd1802fe311c56e58
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=36f39fa8d59ae8d07c839c0cd1802fe311c56e58
remote: recorded changegroup in replication log in 0.101s
Assignee: nobody → bugs
Attachment #8986286 - Flags: review?(mrbkap)
Comment on attachment 8986286 [details] [diff] [review]
ce_upgrade.diff

Review of attachment 8986286 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/CustomElementRegistry.cpp
@@ +981,5 @@
>    return;
>  }
>  
>  void
> +TryUpgrade(nsINode& aNode)

This should probably be `static void`.

@@ +1001,5 @@
> +    }
> +  }
> +
> +  ShadowRoot* root;
> +  if (element && (root = element->GetShadowRoot())) {

This comes right after an `if (element)` block which doesn't assign to `element`, so this can be combined into the previous if statement and the resulting second if statement could then be the more idiomatic:

`if (ShadowRoot* root = element->GetShadowRoot()) {...`
Attachment #8986286 - Flags: review?(mrbkap) → review+
Posted patch ce_upgrade_2.diff (obsolete) — Splinter Review
indeed
aha, there is another unexpected pass
Attachment #8986320 - Attachment is obsolete: true
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/693b36bb1292
Implement customElements.upgrade() , r=mrbkap
missed static void
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c14e3d00d740
Implement customElements.upgrade(), static void TryUpgrade , r=mrbkap
https://hg.mozilla.org/mozilla-central/rev/693b36bb1292
https://hg.mozilla.org/mozilla-central/rev/c14e3d00d740
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.