1443722 - Implement customElements.upgrade()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Domenic Denicola]

Recently added to the spec: https://github.com/whatwg/html/pull/3535

Spec: https://html.spec.whatwg.org/multipage/custom-elements.html#dom-customelementregistry-upgrade

Tests: https://github.com/w3c/web-platform-tests/pull/9869

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: ce_upgrade.diff

Trying to map rather exactly to what the spec has

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/36f39fa8d59ae8d07c839c0cd1802fe311c56e58
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=36f39fa8d59ae8d07c839c0cd1802fe311c56e58
remote: recorded changegroup in replication log in 0.101s

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8986286 [details] [diff] [review]
ce_upgrade.diff

Review of attachment 8986286 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/CustomElementRegistry.cpp
@@ +981,5 @@
>    return;
>  }
>  
>  void
> +TryUpgrade(nsINode& aNode)

This should probably be `static void`.

@@ +1001,5 @@
> +    }
> +  }
> +
> +  ShadowRoot* root;
> +  if (element && (root = element->GetShadowRoot())) {

This comes right after an `if (element)` block which doesn't assign to `element`, so this can be combined into the previous if statement and the resulting second if statement could then be the more idiomatic:

`if (ShadowRoot* root = element->GetShadowRoot()) {...`

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: ce_upgrade_2.diff

indeed

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

aha, there is another unexpected pass

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: ce_upgrade_2.diff

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/693b36bb1292
Implement customElements.upgrade() , r=mrbkap

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: static_void.diff

missed static void

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c14e3d00d740
Implement customElements.upgrade(), static void TryUpgrade , r=mrbkap

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/693b36bb1292
https://hg.mozilla.org/mozilla-central/rev/c14e3d00d740