Closed
Bug 1443727
Opened 6 years ago
Closed 6 years ago
[MIPS] Fix miscellaneous build warnings
Categories
(Core :: JavaScript Engine, enhancement, P5)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: dragan.mladjenovic, Assigned: dragan.mladjenovic)
Details
Attachments
(1 file)
|
4.53 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → dragan.mladjenovic
Attachment #8956728 -
Flags: review?(bbouvier)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8956728 [details] [diff] [review] bug1443727.patch Review of attachment 8956728 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jit/mips-shared/Assembler-mips-shared.h @@ +892,5 @@ > > MIPSBufferWithExecutableCopy m_buffer; > > +#ifdef JS_JITSPEW > + Sprinter* printer; What warning does this change silence?
|
|
||
Updated•6 years ago
|
Priority: -- → P5
|
|
Assignee | |
Comment 3•6 years ago
|
||
(In reply to Jason Orendorff [:jorendorff] from comment #2) > Comment on attachment 8956728 [details] [diff] [review] > bug1443727.patch > > Review of attachment 8956728 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: js/src/jit/mips-shared/Assembler-mips-shared.h > @@ +892,5 @@ > > > > MIPSBufferWithExecutableCopy m_buffer; > > > > +#ifdef JS_JITSPEW > > + Sprinter* printer; > > What warning does this change silence? warning: field 'm_buffer' will be initialized after field 'printer' [-Wreorder]
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8956728 [details] [diff] [review] bug1443727.patch Review of attachment 8956728 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. ::: js/src/jit/mips-shared/Assembler-mips-shared.h @@ +892,5 @@ > > MIPSBufferWithExecutableCopy m_buffer; > > +#ifdef JS_JITSPEW > + Sprinter* printer; Probably this printer is unused in non JS_JITSPEW builds? (not sure the compiler could infer this, though)
Attachment #8956728 -
Flags: review?(bbouvier) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cba4601c84f0 [MIPS] Fix miscellaneous build warnings r=bbouvier
Keywords: checkin-needed
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cba4601c84f0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•