Closed Bug 1443736 Opened 2 years ago Closed 2 years ago

Better handing of xdg-open in the snap

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set

Tracking

(firefox59 fixed, firefox60 fixed)

RESOLVED FIXED
Tracking Status
firefox59 --- fixed
firefox60 --- fixed

People

(Reporter: ken.vandine, Assigned: ken.vandine)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180305193205

Steps to reproduce:

Snaps need to use xdg-open to handle opening files that have been downloaded.  We should bundle a mimeapps.list.
Blocks: 1442419
Comment on attachment 8956740 [details]
Bug 1443736 - Improved mechanism for handing opening files after downloading with snap

https://reviewboard.mozilla.org/r/225708/#review231546

This makes sense to me.
Attachment #8956740 - Flags: review?(jlorenzo) → review+
Pushed by jlorenzo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/391c1ae6bb0d
Improved mechanism for handing opening files after downloading with snap r=jlorenzo
Assignee: nobody → ken.vandine
Comment on attachment 8956740 [details]
Bug 1443736 - Improved mechanism for handing opening files after downloading with snap

Approval Request Comment
[Feature/Bug causing the regression]: None
[User impact if declined]: Ubuntu users running Snaps won't be able to open downloaded files.
[Is this code covered by automated tests?]: N/A
[Has the fix been verified in Nightly?]: N/A. Releng crafts Snap on beta. Starting Firefox 59, Snap are also built on release.
[Needs manual test from QE? If yes, steps to reproduce]: No. This has been tested by Canonical's QA.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is a Snap only fix for 59. It has no impact on the regular product.
[String changes made/needed]: None.
Attachment #8956740 - Flags: approval-mozilla-release?
https://hg.mozilla.org/mozilla-central/rev/391c1ae6bb0d
Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Comment on attachment 8956740 [details]
Bug 1443736 - Improved mechanism for handing opening files after downloading with snap

Snap-only fix, let's uplift.
Attachment #8956740 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.