1443736 - Better handing of xdg-open in the snap

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Ken VanDine]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180305193205

Steps to reproduce:

Snaps need to use xdg-open to handle opening files that have been downloaded.  We should bundle a mimeapps.list.

Comment 1

[Ken VanDine]

Attachment: Bug 1443736 - Improved mechanism for handing opening files after downloading with snap

Review commit: https://reviewboard.mozilla.org/r/225708/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225708/

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8956740 [details]
Bug 1443736 - Improved mechanism for handing opening files after downloading with snap

https://reviewboard.mozilla.org/r/225708/#review231546

This makes sense to me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/391c1ae6bb0d
Improved mechanism for handing opening files after downloading with snap r=jlorenzo

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8956740 [details]
Bug 1443736 - Improved mechanism for handing opening files after downloading with snap

Approval Request Comment
[Feature/Bug causing the regression]: None
[User impact if declined]: Ubuntu users running Snaps won't be able to open downloaded files.
[Is this code covered by automated tests?]: N/A
[Has the fix been verified in Nightly?]: N/A. Releng crafts Snap on beta. Starting Firefox 59, Snap are also built on release.
[Needs manual test from QE? If yes, steps to reproduce]: No. This has been tested by Canonical's QA.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is a Snap only fix for 59. It has no impact on the regular product.
[String changes made/needed]: None.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/391c1ae6bb0d

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8956740 [details]
Bug 1443736 - Improved mechanism for handing opening files after downloading with snap

Snap-only fix, let's uplift.

Comment 7

[Johan Lorenzo [:jlorenzo]]

Landed on release at https://hg.mozilla.org/releases/mozilla-release/rev/08d230e4b91e3d85d95d2e528e7cc95d645a9a47