Closed Bug 1443839 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 9900 - Fixed firefox binary path for Windows and Mac in browser.py

Categories

(Testing :: web-platform-tests, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 9900 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9900
Details from upstream follow.

Cactusmachete wrote:
>  Fixed firefox binary path for Windows and Mac in browser.py
>  
>  find_executable() earlier returned None for non-linux systems, causing
>  firefox browser install to fail. Added the different binary paths for each OS.
>  Also removed platform_string() which used to be called in install() before nightly
>  download depended on mozdownload, and is now dead code.
>  Removed xfail for firefox install and run on MacOS in test_wpt.py as it will work now.
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c5135b8fe41
[wpt PR 9900] - Fixed firefox binary path for Windows and Mac in browser.py, a=testonly
https://hg.mozilla.org/mozilla-central/rev/4c5135b8fe41
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.