Closed Bug 1443900 Opened 6 years ago Closed 6 years ago

don't allocate nsCStrings when doing integer parsing

Categories

(Core :: Networking: Cache, enhancement)

Product:
Core
Component:
Networking: Cache
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

don't allocate nsCStrings when doing integer parsing
3.11 KB, patch
michal
: review+
Details | Diff | Splinter Review 
There's no need to allocate a completely new nsCString when all we want
to do is parse a character string into an integer.  We can allocate a
dependent string instead, which will avoid some memory churn.
We should really be parsing the `const char*` directly, but one step at a
time...
Attachment #8956933 - Flags: review?(michal.novotny)
Attachment #8956933 - Flags: review?(michal.novotny) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f64845d179b
don't allocate nsCStrings when doing integer parsing; r=michal
https://hg.mozilla.org/mozilla-central/rev/0f64845d179b
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.