Closed
Bug 1443900
Opened 7 years ago
Closed 7 years ago
don't allocate nsCStrings when doing integer parsing
Categories
(Core :: Networking: Cache, enhancement)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
3.11 KB,
patch
|
michal
:
review+
|
Details | Diff | Splinter Review |
There's no need to allocate a completely new nsCString when all we want
to do is parse a character string into an integer. We can allocate a
dependent string instead, which will avoid some memory churn.
Assignee | ||
Comment 1•7 years ago
|
||
We should really be parsing the `const char*` directly, but one step at a
time...
Attachment #8956933 -
Flags: review?(michal.novotny)
Updated•7 years ago
|
Attachment #8956933 -
Flags: review?(michal.novotny) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f64845d179b
don't allocate nsCStrings when doing integer parsing; r=michal
Comment 3•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•