Closed
Bug 1443958
Opened 6 years ago
Closed 6 years ago
Synthesizing a click() on input type=date should not show the date picker UI
Categories
(Core :: DOM: Core & HTML, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla61
People
(Reporter: miketaylr, Assigned: smaug)
References
()
Details
(Whiteboard: [webcompat:p1])
User Story
Business driver: Achieve tier-1 Google Search experience for Gecko on Android
Attachments
(1 file, 1 obsolete file)
2.28 KB,
patch
|
jcristau
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Per https://github.com/whatwg/html/issues/3232, Firefox is the only browser that allows dispatching a synthetic click event to open the date picker UI: Here's a simple test case: https://output.jsbin.com/sonopow/quiet We should match the other major browsers behavior here, for interop.
Reporter | ||
Updated•6 years ago
|
Flags: webcompat+
Whiteboard: [webcompat:p2]
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 1•6 years ago
|
||
Setting to [webcompat:p1] because this affects Google Tier 1 Search.
Whiteboard: [webcompat:p2] → [webcompat:p1]
Updated•6 years ago
|
Priority: -- → P2
Assignee | ||
Updated•6 years ago
|
Component: DOM: Events → DOM: Core & HTML
Assignee | ||
Comment 2•6 years ago
|
||
This is trivial, at least on desktop. And doesn't seem to apply to mobile.
Assignee: nobody → bugs
Assignee | ||
Comment 3•6 years ago
|
||
This is a very small patch :) remote: View your change here: remote: https://hg.mozilla.org/try/rev/2bc9d7050b66ef4d34abccefcc953f0aff3e4e2b remote: remote: Follow the progress of your build on Treeherder: remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2bc9d7050b66ef4d34abccefcc953f0aff3e4e2b remote: recorded changegroup in replication log in 0.095s
Attachment #8963725 -
Flags: review?(mconley)
Comment 4•6 years ago
|
||
Comment on attachment 8963725 [details] [diff] [review] date_click.diff Review of attachment 8963725 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! ::: toolkit/content/widgets/datetimebox.xml @@ +1255,5 @@ > // Handle keypress separately since we need to catch it on capturing. > this.addEventListener("keypress", this, { > capture: true, > mozSystemGroup: true > + }, Nit - I think it's usually more common to have these on the same line, like: this.addEventListener("keypress", this, { capture: true, mozSystemGroup: true, }, false);
Attachment #8963725 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 5•6 years ago
|
||
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/223010e3a593 Synthesizing a click() on input type=date should not show the date picker UI , r=mconley
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/223010e3a593
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 8•6 years ago
|
||
Should we get this on 60 to avoid webcompat pain on esr?
Flags: needinfo?(bugs)
Assignee | ||
Comment 9•6 years ago
|
||
I don't know. The patch should be quite safe anyhow. Mike may have an opinion.
Flags: needinfo?(bugs) → needinfo?(miket)
Reporter | ||
Comment 10•6 years ago
|
||
Yes, it seems like a good idea, if possible.
Flags: needinfo?(miket)
Assignee | ||
Comment 11•6 years ago
|
||
ok, let me try whether the patches apply to 60
Assignee | ||
Comment 12•6 years ago
|
||
There doesn't seem to have a flag yet for esr60 approval. The patch itself seems to apply.
Flags: needinfo?(jcristau)
Assignee | ||
Comment 14•6 years ago
|
||
Comment on attachment 8963821 [details] [diff] [review] date_click_2.diff Approval Request Comment [Feature/Bug causing the regression]: This has been an issue since we added support for type=date [User impact if declined]: different behavior than in other browsers [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: yes by tests [Needs manual test from QE? If yes, steps to reproduce]: I don't think manual test is needed [List of other uplifts needed for the feature/fix]: NA [Is the change risky?]: shouldn't be too risky. [Why is the change risky/not risky?]: we end up handling trusted-only events like other similar element implementations [String changes made/needed]: NA
Attachment #8963821 -
Flags: approval-mozilla-beta?
Comment 15•6 years ago
|
||
Comment on attachment 8963821 [details] [diff] [review] date_click_2.diff let's get this in 60.0b11
Attachment #8963821 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•6 years ago
|
Attachment #8963725 -
Attachment is obsolete: true
Comment 16•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/456c098f27d4
Flags: in-testsuite+
Reporter | ||
Updated•6 years ago
|
User Story: (updated)
You need to log in
before you can comment on or make changes to this bug.
Description
•