Closed Bug 1443966 Opened 6 years ago Closed 6 years ago

Add missing includes for nsIContent::IsInChromeDocument.

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1443966: Add missing include for nsIContent::IsInChromeDocument.
59 bytes, text/x-review-board-request
dholbert
: review+
Details 
Apparently people like to implement virtual functions in *Inlines.h headers.

This is busting the MinGW build.
Hi Daniel, here's a try run for MinGW, mind landing this patch if it looks fine to you and it comes out green?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=36ceb980cecba2c795d086158451e9a2e6c338ca
Flags: needinfo?(dholbert)
Comment on attachment 8957022 [details]
Bug 1443966: Add missing include for nsIContent::IsInChromeDocument.

https://reviewboard.mozilla.org/r/225986/#review231882

Looks good to me! And yup, I'll land this if the try run passes.
Attachment #8957022 - Flags: review?(dholbert) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4bc59f0d944b
Add missing include for nsIContent::IsInChromeDocument. r=dholbert
MinGW Bo build is green, and I think that's the one we were looking to fix here. Triggered autoland.
https://hg.mozilla.org/mozilla-central/rev/4bc59f0d944b
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Flags: needinfo?(dholbert)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: