Closed Bug 1444024 Opened 2 years ago Closed 2 years ago

Port bug 1443604 to TB: Flatten handler bindings

Categories

(Thunderbird :: Preferences, enhancement)

Product:
Thunderbird
Component:
Preferences
Type:
enhancement
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 60.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

flattenHandlers.patch
5.05 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
ui font.png
6.75 KB, image/png
Details 
This looks easy to port and if we can simplify the xml, then let's do it.
Direct port of https://hg.mozilla.org/mozilla-central/rev/b8b7a46f6a24a81029c6f18bce0802db060e6aa2

I only changed the 'gMainPane' to 'gApplicationsPane'.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8957070 - Flags: review?(jorgk)
I can review this tonight, it still works without it, right?
Yes, it's no bustage fix.
Comment on attachment 8957070 [details] [diff] [review]
flattenHandlers.patch

I looked at the "in content" preferences and see no difference with the patch.

However, the text size in those preferences is now much smaller than in a build of two days ago, 60.0a1 (2018-03-06) (64-bit). That affects both the right and the left sides. In fact, the "in content" option and the Add-on Manager now have different text size and spacing. The spacing is now 40px for options and 50px for add-ons. So that looks pretty inconsistent now :-(

I this a known issue?
Flags: needinfo?(richard.marti)
Attachment #8957070 - Flags: review?(jorgk) → review+
There was no recent change. I see also no change in size between today build and a older one. The spacing is the same of FX. The difference is better visible because we use a gray background on the left.
Flags: needinfo?(richard.marti)
Keywords: checkin-needed
Attached image ui font.png — 
Wow, changing the default font also changes the font of the "in content" prefs :-(

I had Calibri in my testing profile and that was smaller. This makes it inconsistent with the Add-ons Manager. I think this is a bug.
Do you want to file a bug? Then I can look if I can define to use the same font as the Add-ons Manager.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/53f6ed4e68bc
Port bug 1443604 to TB: Flatten handler bindings. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 60.0
You need to log in before you can comment on or make changes to this bug.