1444036 - Remove trivial usage of getPropertyCSSValue from the tree.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

getPropertyCSSValue("foo").cssText is just getPropertyValue("foo")

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1444036: Remove trivial uses of getPropertyCSSValue.

Review commit: https://reviewboard.mozilla.org/r/226042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226042/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8957089 [details]
Bug 1444036: Remove trivial uses of getPropertyCSSValue.

https://reviewboard.mozilla.org/r/226042/#review231978

rs=me, assuming that you know what you're talking about and it's really the same thing :)

::: devtools/client/shared/inplace-editor.js:1565
(Diff revision 1)
>   *        the element from which styles are copied
>   * @param {DOMNode} to
>   *        the element on which copied styles are applied
>   */
>  function copyBoxModelStyles(from, to) {
> -  let win = from.ownerDocument.defaultView;
> +  const properties = [

nit: please be consistent in your usage of let/const and use let here :)

::: devtools/client/shared/inplace-editor.js:1585
(Diff revision 1)
> -  to.style.borderLeftWidth = getCssText("border-left-width");
> +    "borderLeftWidth"
> +  ];
> +
> +  let win = from.ownerDocument.defaultView;
> +  let style = win.getComputedStyle(from);
> +  for (const property of properties)

nit: let property

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d15070cd21f4
Remove trivial uses of getPropertyCSSValue. rs=johannh

Comment 4

[Emilio Cobos Álvarez (:emilio)]

(In reply to Johann Hofmann [:johannh] from comment #2)
> Comment on attachment 8957089 [details]
> Bug 1444036: Remove trivial uses of getPropertyCSSValue.
> 
> https://reviewboard.mozilla.org/r/226042/#review231978
> 
> rs=me, assuming that you know what you're talking about and it's really the
> same thing :)
> 
> ::: devtools/client/shared/inplace-editor.js:1565
> (Diff revision 1)
> >   *        the element from which styles are copied
> >   * @param {DOMNode} to
> >   *        the element on which copied styles are applied
> >   */
> >  function copyBoxModelStyles(from, to) {
> > -  let win = from.ownerDocument.defaultView;
> > +  const properties = [
> 
> nit: please be consistent in your usage of let/const and use let here :)

Well, it's not my usage, it was pre-existent and thus didn't touch it, but done.

> ::: devtools/client/shared/inplace-editor.js:1585
> (Diff revision 1)
> > -  to.style.borderLeftWidth = getCssText("border-left-width");
> > +    "borderLeftWidth"
> > +  ];
> > +
> > +  let win = from.ownerDocument.defaultView;
> > +  let style = win.getComputedStyle(from);
> > +  for (const property of properties)
> 
> nit: let property

Done

Thanks for the review!

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d15070cd21f4