1444088 - review link for patches on the requests page no longer shows up

Status: VERIFIED FIXED

(bugzilla.mozilla.org :: Splinter, defect)

Description

[Nathan Froyd [:froydnj]]

STR:

1. Go to somebody's requests page; the page below is for the shared review queue for :build-peer.

https://bugzilla.mozilla.org/request.cgi?action=queue&requester=&product=&type=all&requestee=core-build-config-reviews%40mozilla.bugs&component=&group=type&do_union=1

Expected results:

The "Attachment" column contains a [details] link and a [review] link for each patch.

Actual results:

The "Attachment" column contains only a [details] link.

This means to review patches in splinter requires extra clicks from this page, which is inconvenient.  This behavior is a recent regression.

Comment 1

[Kohei Yoshino]

Ugh, that's probably me. sigh :(

In https://github.com/mozilla-bteam/bmo/pull/372 I said `ispatch` "field is not used in other templates so the change should be safe" but there is:

https://github.com/mozilla-bteam/bmo/blob/master/extensions/Splinter/template/en/default/hook/request/queue-after_column.html.tmpl

Will fix it once I get the virtual machine at home.

Comment 2

[Nathan Froyd [:froydnj]]

Thank you!

Comment 3

[Kohei Yoshino]

Attachment: pull request

Comment 4

[Nathan Froyd [:froydnj]]

I'm still seeing this, but I assume this is actually fixed and simply not yet pushed to the actual bugzilla instance?

Comment 5

[Kohei Yoshino]

Yes, this is not live yet. I'm sure when it goes production.

Comment 6

[Kohei Yoshino]

I mean: not sure...

Comment 7

[Dylan Hardison [:dylan] (he/him)]

There was a bit of a delay getting this out because of a large amount of work for the cloud migration. It is now live though.