Closed Bug 1444094 Opened 2 years ago Closed 2 years ago

Remove support for the "places/excludeFromBackup" annotation

Categories

(Toolkit :: Places, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Since at least the bookmarks import switch to async, we have only really supported the "places/excludeFromBackup" at the root-level of bookmarks.

In bug 1443835, we are removing support for user folders at the root-level.

Therefore, we should:

- Completely remove support for the annotation (e.g. avoid checking it in various places), including WebExt & Sync.
- Remove the annotation from user's databases (Probably keep the bookmark data if it is in one of the built-in roots).
Yay, I'm happy this is happening! Sync hasn't used the annotation to filter out bookmarks since bug 1274496, so we should be good there. The migration strategy makes sense to me. If a bookmark has that anno, and is in one of the user content roots, Sync will sync it anyway, and won't set the anno on other devices.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Priority: P2 → P1
As per bug 1306445, I think we can leave the old annotations in the database, and potentially clean them up later - generally most people won't have any, there may be a few who were using extensions that have them.
Comment on attachment 8961040 [details]
Bug 1444094 - Remove remaining support for the places/excludeFromBackup annotation.

https://reviewboard.mozilla.org/r/229786/#review235762

This is great!
Attachment #8961040 - Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/562edc8ff727
Remove remaining support for the places/excludeFromBackup annotation. r=mak
https://hg.mozilla.org/mozilla-central/rev/562edc8ff727
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.