1444094 - Remove support for the "places/excludeFromBackup" annotation

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P1)

Description

[Mark Banner (:standard8)]

Since at least the bookmarks import switch to async, we have only really supported the "places/excludeFromBackup" at the root-level of bookmarks.

In bug 1443835, we are removing support for user folders at the root-level.

Therefore, we should:

- Completely remove support for the annotation (e.g. avoid checking it in various places), including WebExt & Sync.
- Remove the annotation from user's databases (Probably keep the bookmark data if it is in one of the built-in roots).

Comment 1

[Lina Butler (ex-Mozilla)]

Yay, I'm happy this is happening! Sync hasn't used the annotation to filter out bookmarks since bug 1274496, so we should be good there. The migration strategy makes sense to me. If a bookmark has that anno, and is in one of the user content roots, Sync will sync it anyway, and won't set the anno on other devices.

Comment 2

[Mark Banner (:standard8)]

As per bug 1306445, I think we can leave the old annotations in the database, and potentially clean them up later - generally most people won't have any, there may be a few who were using extensions that have them.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1444094 - Remove remaining support for the places/excludeFromBackup annotation.

Review commit: https://reviewboard.mozilla.org/r/229786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229786/

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8961040 [details]
Bug 1444094 - Remove remaining support for the places/excludeFromBackup annotation.

https://reviewboard.mozilla.org/r/229786/#review235762

This is great!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/562edc8ff727
Remove remaining support for the places/excludeFromBackup annotation. r=mak

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/562edc8ff727