Closed Bug 1444119 Opened 2 years ago Closed 2 years ago

Remove XPCOM extensibility of XSLT functions

Categories

(Core :: XSLT, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: peterv, Assigned: peterv)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch v1 (obsolete) — Splinter Review
We don't need this complexity (I think XForms used it at one point), we can just call the remaining JS code directly.
Assignee: nobody → peterv
Status: NEW → ASSIGNED
Attachment #8957208 - Flags: review?(bzbarsky)
Attachment #8957208 - Attachment is obsolete: true
Attachment #8957208 - Flags: review?(bzbarsky)
Attached patch v1Splinter Review
Attachment #8957281 - Flags: review?(bzbarsky)
Comment on attachment 8957281 [details] [diff] [review]
v1

>+++ b/dom/xslt/txIEXSLTRegExFunctions.idl

>+    void match(in DOMString aString, in DOMString aRegEx, in DOMString aFlags,
>+               in nsIDOMDocumentFragment aResultDocumentFragment);

Why is this not just returning the documentfragment?

>@@ -661,75 +683,223 @@ txEXSLTFunctionCall::evaluate(txIEvalCon
>-    return NS_ERROR_UNEXPECTED;

We should have some sort of notreached annotation here, I would think.  It's not obvious that all branches of the switch return.

r=me
Attachment #8957281 - Flags: review?(bzbarsky) → review+
Priority: -- → P2
https://hg.mozilla.org/integration/mozilla-inbound/rev/bca28a3a066affab25f49b49767f650a42772675
Bug 1444119 - Remove XPCOM extensibility of XSLT functions. Fix build bustage on a CLOSED TREE.
https://hg.mozilla.org/mozilla-central/rev/91ff76ff96e3
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Flags: needinfo?(peterv)
You need to log in before you can comment on or make changes to this bug.