1444119 - Remove XPCOM extensibility of XSLT functions

Status: RESOLVED FIXED

(Core :: XSLT, enhancement, P2)

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v1

We don't need this complexity (I think XForms used it at one point), we can just call the remaining JS code directly.

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8957281 [details] [diff] [review]
v1

>+++ b/dom/xslt/txIEXSLTRegExFunctions.idl

>+    void match(in DOMString aString, in DOMString aRegEx, in DOMString aFlags,
>+               in nsIDOMDocumentFragment aResultDocumentFragment);

Why is this not just returning the documentfragment?

>@@ -661,75 +683,223 @@ txEXSLTFunctionCall::evaluate(txIEvalCon
>-    return NS_ERROR_UNEXPECTED;

We should have some sort of notreached annotation here, I would think.  It's not obvious that all branches of the switch return.

r=me

Comment 4

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3181f8c1a5399ce0f056f2ddeb23f2ddd8cd7faf
Bug 1444119 - Remove XPCOM extensibility of XSLT functions. r=bz.

Comment 5

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bca28a3a066affab25f49b49767f650a42772675
Bug 1444119 - Remove XPCOM extensibility of XSLT functions. Fix build bustage on a CLOSED TREE.

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for build bustages on dom/xslt/xslt/txEXSLTFunctions.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=busted&filter-resultStatus=exception&fromchange=ccdf91217b3c6e386a357e0db863b59a952b12ac&tochange=79c8f6eb9b2110639d6988d2f5b5cb740c15f69e&selectedJob=169831749

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=169831749&repo=mozilla-inbound&lineNumber=19380

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/79c8f6eb9b2110639d6988d2f5b5cb740c15f69e

Comment 7

[Peter Van der Beken [:peterv]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c799f03da0e3e80649e396cbf56e07723440909

Comment 8

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/91ff76ff96e3da328aeab0b1f13fb47bae87fc9f
Bug 1444119 - Remove XPCOM extensibility of XSLT functions. r=bz.

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/91ff76ff96e3