./mach test fails for Marionette tests

RESOLVED FIXED in Firefox 60

Status

defect
RESOLVED FIXED
Last year
6 months ago

People

(Reporter: tjr, Assigned: ahal)

Tracking

({regression})

3 Branch
mozilla61
Dependency tree / graph

Firefox Tracking Flags

(firefox59 unaffected, firefox60 fixed, firefox61 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

Last year
but ./mach marionette-test browser/components/migration/tests/marionette/test_refresh_firefox.py does
This is for all Marionette tests. The failure as shown is:

Error running mach:

    ['test', 'testing/marionette']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: marionette() got an unexpected keyword argument 'test_objects'

  File "/Volumes/data/code/gecko/testing/mach_commands.py", line 164, in test
    argv=extra_args, test_objects=tests, **kwargs)
  File "/Volumes/data/code/gecko/python/mach/mach/registrar.py", line 129, in dispatch
    return self._run_command_handler(handler, context=context, **kwargs)
  File "/Volumes/data/code/gecko/python/mach/mach/registrar.py", line 90, in _run_command_handler
    result = fn(**kwargs)
Summary: ./mach test browser/components/migration/tests/marionette/test_refresh_firefox.py does not work → ./mach test fails for Marionette tests
This is a regression from bug 1437912:

The first bad revision is:
changeset:   450752:45810ed08842
user:        Andrew Halberstadt <ahalberstadt@mozilla.com>
date:        Tue Feb 13 14:16:46 2018 -0500
summary:     Bug 1437912 - [moztest] Map flavors and subsuites to a suite definition, r=gbrown
Blocks: 1437912
Flags: needinfo?(ahalberstadt)
Keywords: regression
Assignee

Updated

Last year
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Flags: needinfo?(ahalberstadt)
Comment hidden (mozreview-request)

Comment 4

Last year
mozreview-review
Comment on attachment 8958441 [details]
Bug 1444152 - [test] Fix regression running marionette tests with |mach test|,

https://reviewboard.mozilla.org/r/227404/#review234992
Attachment #8958441 - Flags: review?(hskupin) → review+

Comment 5

Last year
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28088e11bfc4
[test] Fix regression running marionette tests with |mach test|, r=whimboo
https://hg.mozilla.org/mozilla-central/rev/28088e11bfc4
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Whiteboard: [checkin-needed-beta]
Keywords: regression
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.