1444152 - ./mach test fails for Marionette tests

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

but ./mach marionette-test browser/components/migration/tests/marionette/test_refresh_firefox.py does

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is for all Marionette tests. The failure as shown is:

Error running mach:

    ['test', 'testing/marionette']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: marionette() got an unexpected keyword argument 'test_objects'

  File "/Volumes/data/code/gecko/testing/mach_commands.py", line 164, in test
    argv=extra_args, test_objects=tests, **kwargs)
  File "/Volumes/data/code/gecko/python/mach/mach/registrar.py", line 129, in dispatch
    return self._run_command_handler(handler, context=context, **kwargs)
  File "/Volumes/data/code/gecko/python/mach/mach/registrar.py", line 90, in _run_command_handler
    result = fn(**kwargs)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is a regression from bug 1437912:

The first bad revision is:
changeset:   450752:45810ed08842
user:        Andrew Halberstadt <[e-mail]>
date:        Tue Feb 13 14:16:46 2018 -0500
summary:     Bug 1437912 - [moztest] Map flavors and subsuites to a suite definition, r=gbrown

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1444152 - [test] Fix regression running marionette tests with |mach test|,

There were two issues:
1) The mach command name in resolve.py was wrong.
2) The marionette harness uses deepcopy on the passed in kwargs and sometimes
the 'log' argument that testing/mach_commands.py was passing in can be a class
instance (which can't be deepcopied).

Review commit: https://reviewboard.mozilla.org/r/227404/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227404/

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8958441 [details]
Bug 1444152 - [test] Fix regression running marionette tests with |mach test|,

https://reviewboard.mozilla.org/r/227404/#review234992

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28088e11bfc4
[test] Fix regression running marionette tests with |mach test|, r=whimboo

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/28088e11bfc4

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4991a778dc7e