1444158 - "Show search suggestions in address bar results" checkbox from the about:preferences#search page shows up ticked (and grayed out) if unticking 'Provide search suggestions'

Status: RESOLVED WONTFIX

(Firefox :: Settings UI, defect)

Description

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
This issue was fixed for 60 in bug 1438180, but the fix was backed out in 59 for causing bug 1443229. We're evaluating whether we want to fix all of this as a ride-along in a dot-release (if any happens) by relanding the fix from 1438180 plus the fix from 1443229 in one patch.

(In reply to Emil Ghitta, QA [:emilghitta] from bug 1438180 comment #0)
> [Steps to reproduce]:
> 1. Launch Firefox with a clean profile.
> 2. Access the about:preferences#search page.
> 3. Untick the "Provide search suggestions" checkbox.
> 4. Restart Firefox.
> 5. Access the about:preferences#search page.
> 
> [Expected result]:
> The following checkboxes are displayed garyed out and unticked:
> - "Show search suggestions in address bar results".
> - "Show search suggestions ahead of browsing history in address bar results".
> 
> [Actual result]:
> The "Show search suggestions in address bar results" checkbox is displayed
> ticked and grayed out.

Comment 1

[:Gijs (he/him)]

Attachment: Patch for mozilla-release

Approval Request Comment
[Feature/Bug causing the regression]: unclear, race condition seemingly triggered by fix from bug 1393437
[User impact if declined]: checkbox in prefs looks ticked when it should look unticked in some circumstances
[Is this code covered by automated tests?]: somewhat as part of this patch
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: yes, steps from bug 1438180 comment #0 and verifying that changing the checkbox state of 'Show search suggestions in address bar results' (when not disabled (grayed out)) also changes the urlbar search pref (browser.urlbar.suggest.searches).
[List of other uplifts needed for the feature/fix]: none, I already combined the grafted csets into 1 patch
[Is the change risky?]: not really
[Why is the change risky/not risky?]: this is all verified-on-nightly code, and has an automated test
[String changes made/needed]: no

Comment 2

[:Gijs (he/him)]

I believe that after the changes from bug 1444548, this is fixed for 59 as well. Emil, after any other testing you're doing for bug 1444548, can you doublecheck my testing for this issue? (I tested locally with a mozilla-release build downloaded from the change that :adw landed, on macOS only)

Going to close this out for now, hoping QE can verify.

Comment 3

[:Gijs (he/him)]

OK, per discussion with Emil, it seems this is actually still happening on 59 post-bug 1444548, but only if you either:

1) restart with sessionrestore open on about:preferences#search (or do so e.g. via the GCLI)
2) directly open about:preferences#search

I think this isn't important enough to worry about for 59, so marking wontfix.

Comment 4

[Emil Ghitta, QA [:emilghitta]]

Thanks Gijs for helping me clarify this! 

Marking this as verified for 60.0b3 (BuildId:20180312152746) using Windows 10 64bit, macOS 10.13 and Ubuntu 16.04 64bit.