Closed
Bug 1444162
Opened 3 years ago
Closed 3 years ago
Change button copy in reconnect state
Categories
(Firefox :: Sync, enhancement, P1)
Tracking
()
RESOLVED
FIXED
Firefox 61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: rfeeley, Assigned: tcsc)
References
Details
Attachments
(2 files)
remove-account.png
As a button label, "Cancel Setup" makes sense before verification, but after a password change, it should probably instead say "Remove Account" (even though it does the same thing). See attached.
|
||
Updated•3 years ago
|
Assignee: nobody → tchiovoloni
Priority: -- → P1
| Comment hidden (mozreview-request) |
|
||
Comment 2•3 years ago
|
||
| mozreview-review | ||
Comment on attachment 8960253 [details] Bug 1444162 - Replace 'Cancel Setup' string with 'Remove Account' https://reviewboard.mozilla.org/r/229014/#review234756 Thanks!
Attachment #8960253 -
Flags: review?(eoger) → review+
Pushed by tchiovoloni@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/596a02e251a1 Replace 'Cancel Setup' string with 'Remove Account' r=eoger
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/596a02e251a1
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
|
||
Comment 5•3 years ago
|
||
Why did you pick "p" as access key for a label that doesn't have that character in it? This is going to show up as "Remove Account (p)" on any system but macOS. Note: you don't need a new string ID to fix it.
Flags: needinfo?(tchiovoloni)
|
Assignee | |
Comment 6•3 years ago
|
||
Oof, yeah that looks dumb. Good catch, sorry about that, filed 1448063.
Flags: needinfo?(tchiovoloni)
You need to log in
before you can comment on or make changes to this bug.
Description
•