1444169 - Clean up all MinGw capitalization issues

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

If we're going to land Bug 1444167, there will be a few capitalization issues that will need to be fixed before-hand. This bug is for fixing them.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1444169 Fix capitalization for a few Windows files

MinGW headers are all lowercase, and because we build FF with MinGW
on Linux - capitalization matters.  But if you're plugging along,
working on Windows, you might forget about that, and wind up
inadvertently breaking the MinGW build because you capitalized
an include file (as is common in Windows development.)

This lint job takes the list of header files from MinGW
(generated by cd mingw-w64/mingw-w64-headers &&
  find . -name "*.h" | xargs -I bob -- basename bob | sort | uniq)
and will alert if they are in an #include statement but not
all-lowercase.

Review commit: https://reviewboard.mozilla.org/r/226194/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226194/

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8957272 [details]
Bug 1444169 Fix capitalization for a few Windows files

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226194/diff/1-2/

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8957272 [details]
Bug 1444169 Fix capitalization for a few Windows files

https://reviewboard.mozilla.org/r/226194/#review232194

::: gfx/layers/d3d11/CompositorD3D11.cpp:38
(Diff revision 2)
>  
>  #include "D3D11ShareHandleImage.h"
>  #include "DeviceAttachmentsD3D11.h"
>  
> -#ifdef __MINGW32__
>  #include <versionhelpers.h> // For IsWindows8OrGreater

We should just be using our version testing code in MFBT here, but that's not your problem.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93b6538bc167
Fix capitalization for a few Windows files r=aklotz

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/93b6538bc167