Closed Bug 1444289 Opened 2 years ago Closed Last year

[wpt-sync] Sync PR 9934 - [css-typed-om] Generate whitelist from CSSProperties.json5.

Categories

(Core :: DOM: CSS Object Model, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 9934 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9934
Details from upstream follow.

Darren Shen wrote:
>  [css-typed-om] Generate whitelist from CSSProperties.json5.
>  
>  Currently, any CSS property in CSSProperties.json5 with keywords will
>  implicitly accept keywords. This can cause crashes if the property
>  doesn't actually store keywords as CSSIdenifierValues.
>  
>  We solved this by having a manual whitelist of properties we explicitly
>  support. However, this is annoying to maintain. So we generate this
>  whitelist from CSSProperties.json5 by explicitly specifying "Keyword"
>  as a typedom_type.
>  
>  e.g. a property that doesn't have typedom_types will not be supported
>  by Typed OM. A property that has "Keyword" in typedom_types will
>  take CSSKeywordValues and reify as CSSKeywordValues.
>  
>  We also add support for scroll-padding-* because the JSON for that
>  was already there and we just to write a test for it.
>  
>  Diff of generated files:
>  https://gist.github.com/darrnshn/03cb617909abab7bf94aaaaad9874a15/revisions
>  
>  Bug: 820299
>  Change-Id: I6fa01c3623161e0778c5f8764009c6e0cdd6bbf3
>  
>  Reviewed-on: https://chromium-review.googlesource.com/956903
>  WPT-Export-Revision: 827fc5f602e508cc299010e239ab0d625920d1f5
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e1c3b842562
[wpt PR 9934] - [css-typed-om] Generate whitelist from CSSProperties.json5., a=testonly
https://hg.mozilla.org/mozilla-central/rev/8e1c3b842562
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.