Closed Bug 1444325 Opened 2 years ago Closed 2 years ago
Topic Observed with Test Utils .topic Observed in browser _popup Notification .js
59 bytes, text/x-review-board-request
This is a good first bug for newcomers to Firefox development. promiseTopicObserved in the browser_popupNotification.js test file can be replaced by the TestUtils.topicObserved utility function. There are two occurrences we need to replace: https://searchfox.org/mozilla-central/search?q=promiseTopicObserved&case=false®exp=false&path=browser_popupNotification.js For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction. You can run this test with the ./mach mochitest command: ./mach mochitest browser/base/content/test/popupNotifications/browser_popupNotification.js Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.  https://searchfox.org/mozilla-central/rev/588d8120aa11738657da93e09a03378bcd1ba8ec/testing/modules/TestUtils.jsm#56
Hi! Can I give this a try?
I am working On this sir !
I just did my first commit push. Hope it work fine - I have never used Mercurial for committing code before!
Amy was first, we can find another bug for you, Shreya :)
Assignee: nobody → amy_yyc
Status: NEW → ASSIGNED
Comment on attachment 8958060 [details] Bug 1444325 Replaced promiseTopicObserved with TestUtils.topicObserved: https://reviewboard.mozilla.org/r/227002/#review232740 This looks good, thank you. I'm going to set the checkin-needed flag in order to get this landed. We usually do a run on our try server (https://wiki.mozilla.org/ReleaseEngineering/TryServer) to make sure all tests are still passing, but in this case I think we can skip that.
Attachment #8958060 - Flags: review?(jhofmann) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/6ce51cd7a60d Replaced promiseTopicObserved with TestUtils.topicObserved: r=johannh
Hi Johann, Can you assign me other bug? Thank you!
(In reply to Shreya Sonawane from comment #9) > Hi Johann, > > Can you assign me other bug? > Thank you! Hi Shreya, how about bug 1353536? Thanks!
You need to log in before you can comment on or make changes to this bug.