1444325 - Replace promiseTopicObserved with TestUtils.topicObserved in browser_popupNotification.js

Status: RESOLVED FIXED

(Toolkit :: Notifications and Alerts, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

promiseTopicObserved in the browser_popupNotification.js test file can be replaced by the TestUtils.topicObserved[0] utility function.

There are two occurrences we need to replace: https://searchfox.org/mozilla-central/search?q=promiseTopicObserved&case=false&regexp=false&path=browser_popupNotification.js

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/popupNotifications/browser_popupNotification.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

[0] https://searchfox.org/mozilla-central/rev/588d8120aa11738657da93e09a03378bcd1ba8ec/testing/modules/TestUtils.jsm#56

Comment 1

[Amy Chan (:amychan331)]

Hi! Can I give this a try?

Comment 2

[Shreya Sonawane]

I am working On this sir !

Comment 3

[Amy Chan (:amychan331)]

Attachment: Bug 1444325 Replaced promiseTopicObserved with TestUtils.topicObserved:

Review commit: https://reviewboard.mozilla.org/r/227002/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227002/

Comment 4

[Amy Chan (:amychan331)]

I just did my first commit push. Hope it work fine - I have never used Mercurial for committing code before!

Comment 5

[Johann Hofmann [:johannh]]

Amy was first, we can find another bug for you, Shreya :)

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8958060 [details]
Bug 1444325 Replaced promiseTopicObserved with TestUtils.topicObserved:

https://reviewboard.mozilla.org/r/227002/#review232740

This looks good, thank you.

I'm going to set the checkin-needed flag in order to get this landed.

We usually do a run on our try server (https://wiki.mozilla.org/ReleaseEngineering/TryServer) to make sure all tests are still passing, but in this case I think we can skip that.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ce51cd7a60d
Replaced promiseTopicObserved with TestUtils.topicObserved: r=johannh

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/6ce51cd7a60d

Comment 9

[Shreya Sonawane]

Hi Johann,

Can you assign me other bug?
Thank you!

Comment 10

[Johann Hofmann [:johannh]]

(In reply to Shreya Sonawane from comment #9)
> Hi Johann,
> 
> Can you assign me other bug?
> Thank you!

Hi Shreya, how about bug 1353536?

Thanks!