Closed Bug 1444398 Opened 8 years ago Closed 7 years ago

Convert command.html to JS

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, enhancement, P2)

Product:
DevTools Graveyard
Component:
Graphic Commandline and Toolbar
Version:
60 Branch
Type:
enhancement

Tracking

(firefox60 affected)

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox60 --- affected

People

(Reporter: johannh, Unassigned)

References

Details

In command.js we're inserting raw markup from the command.html file using unsafeSetInnerHTML (see bug 1444395) https://searchfox.org/mozilla-central/rev/588d8120aa11738657da93e09a03378bcd1ba8ec/devtools/shared/gcli/source/lib/gcli/languages/command.js#101 We should just build the DOM using JS, which means converting all of this file: https://searchfox.org/mozilla-central/source/devtools/shared/gcli/source/lib/gcli/languages/command.html
Summary: Convert command.html to inline JS → Convert command.html to JS
Can I take this?
(In reply to Trisha from comment #1) > Can I take this? Hi Trisha, thank you for offering to help, but this bug will probably become invalid soon because we have decided to unship GCLI instead of replacing its innerHTML usage. :)
Not going to happen, we're just removing the code.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.